From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 8ee21db4af: Add new function `read-string-from-buffer'. Date: Fri, 29 Apr 2022 08:20:25 -0400 Message-ID: References: <165080616575.16300.17375829044466066664@vcs2.savannah.gnu.org> <20220424131606.1E4FEC009A8@vcs2.savannah.gnu.org> <8735i2wpc0.fsf@athena.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2247"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 14:23:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkPeJ-0000OB-Bj for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 14:23:03 +0200 Original-Received: from localhost ([::1]:52362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkPeI-0004QA-0l for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 08:23:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkPbx-0002V4-Ak for emacs-devel@gnu.org; Fri, 29 Apr 2022 08:20:39 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkPbu-0000An-CN for emacs-devel@gnu.org; Fri, 29 Apr 2022 08:20:35 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0C80A10027D; Fri, 29 Apr 2022 08:20:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 16FB2100124; Fri, 29 Apr 2022 08:20:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651234827; bh=GhzqoYbDhixJHKntcBKYBxIBQ/UbaaKRQqpVUlfP0PM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AF2RNR/kMtGEVS/aEp/uDvkLsE9ksuaq3LpXFD4Fg4ejugQUqDIpKGqag9IOZsb9h j/uG9DKLiFEi7m7wbn7DXZIIVnyf58c+natiuoWTCif17E+8h1xfiQOQxooGE0ux1p sju0Fp/V7JvWRa+HyQJyPs12PhlWDAHnrqLaZhCyO02+tZfc0P3LvAtu9LbC5mbLqf Mlp0FK58ZQV3Za6rYeoboMqOB0GaF3Mebx09/p3hJO9RSpZAuMwEDlNpjkZ0N7/bP7 c5Az5Zijy0RJAdMgwwCpnDbbYHvmx2vImUIFoL9qQFXV4RU3y3upB1lamSLfwfn07T gSvqqXdjzpYRA== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DF0FE120197; Fri, 29 Apr 2022 08:20:26 -0400 (EDT) In-Reply-To: (Jean Louis's message of "Fri, 29 Apr 2022 12:44:41 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288979 Archived-At: Jean Louis [2022-04-29 12:44:41] wrote: > (defun read-from-buffer (&optional value buffer-name mode title keymap place > highlight-list minor-modes) I'd collapse those "mode title keymap place highlight-list minor-modes" into a singe `setup-function` argument. And FWIW, `read-from-buffer` sounds like a good name for a "low-level" function that parallels `read-from-minibuffer` but using a normal window rather than a miniwindow, whereas `read-string-from-buffer` sounds like a replacement for `read-string` (and hence wouldn't take/need a `setup-function` argument). Stefan