From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master e8488bcc9c: Avoid having font locking triggering unnecessary auto-saving
Date: Sat, 07 May 2022 12:06:10 -0400 [thread overview]
Message-ID: <jwvtua12uuy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220507100605.B7CA7C051FF@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 7 May 2022 06:06:05 -0400 (EDT)")
> - (let ((modified (make-symbol "modified")))
> + (let ((modified (make-symbol "modified"))
> + (tick (make-symbol "tick")))
> `(let* ((,modified (buffer-modified-p))
> + (,tick (buffer-modified-tick))
> (buffer-undo-list t)
> (inhibit-read-only t)
> (inhibit-modification-hooks t))
> (unwind-protect
> (progn
> ,@body)
> + ;; We restore the buffer tick count, too, because otherwise
> + ;; we'll trigger a new auto-save.
> + (internal--set-buffer-modified-tick ,tick)
> (unless ,modified
> (restore-buffer-modified-p nil))))))
BTW, I wonder if the auto-save mechanism should use the CHARS_MODIFF
ticks instead?
Stefan
next parent reply other threads:[~2022-05-07 16:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165191796540.22789.3432288633082546349@vcs2.savannah.gnu.org>
[not found] ` <20220507100605.B7CA7C051FF@vcs2.savannah.gnu.org>
2022-05-07 16:06 ` Stefan Monnier [this message]
2022-05-07 16:10 ` master e8488bcc9c: Avoid having font locking triggering unnecessary auto-saving Eli Zaretskii
2022-05-07 16:27 ` Stefan Monnier
2022-05-07 16:40 ` Eli Zaretskii
2022-05-07 17:21 ` Stefan Monnier
2022-05-07 17:26 ` Eli Zaretskii
2022-05-07 16:49 ` Lars Ingebrigtsen
2022-05-09 12:37 ` Lars Ingebrigtsen
2022-05-09 13:22 ` Stefan Monnier
2022-05-09 13:35 ` Lars Ingebrigtsen
2022-05-09 13:47 ` Lars Ingebrigtsen
2022-05-09 15:43 ` Stefan Monnier
2022-05-09 16:05 ` Lars Ingebrigtsen
2022-05-09 16:30 ` Eli Zaretskii
2022-05-09 16:45 ` Lars Ingebrigtsen
2022-05-09 17:40 ` Lars Ingebrigtsen
2022-05-09 18:29 ` Stefan Monnier
2022-05-10 1:51 ` Lars Ingebrigtsen
2022-05-10 2:11 ` Stefan Monnier
2022-05-10 11:45 ` Lars Ingebrigtsen
2022-05-10 11:55 ` Stefan Monnier
2022-05-11 11:22 ` Lars Ingebrigtsen
2022-05-11 13:19 ` Stefan Monnier
2022-05-12 0:18 ` Lars Ingebrigtsen
2022-05-09 17:00 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtua12uuy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).