From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master e8488bcc9c: Avoid having font locking triggering unnecessary auto-saving Date: Sat, 07 May 2022 12:06:10 -0400 Message-ID: References: <165191796540.22789.3432288633082546349@vcs2.savannah.gnu.org> <20220507100605.B7CA7C051FF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19128"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 07 18:08:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnMyl-0004qa-4w for ged-emacs-devel@m.gmane-mx.org; Sat, 07 May 2022 18:08:23 +0200 Original-Received: from localhost ([::1]:36978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnMyj-0000Ze-T0 for ged-emacs-devel@m.gmane-mx.org; Sat, 07 May 2022 12:08:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnMwl-0006lw-Vu for emacs-devel@gnu.org; Sat, 07 May 2022 12:06:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnMwi-00023x-5u for emacs-devel@gnu.org; Sat, 07 May 2022 12:06:18 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BF8B7441133; Sat, 7 May 2022 12:06:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5D49344102B; Sat, 7 May 2022 12:06:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651939571; bh=yn8pfzPQSv/DAkNhpNr8gWuWdC6hm8RbxABKdm9Ia/s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aznlwwE4/Vj8KHRRcTgvOZazR/j0YAOekJnbWaHKQZqDSr1jDKUVrKc7A+dtja5RQ QgGBHr5n0PHrsIKWpO+Jis/nHYV626u/IZd0s1Ptxje/vs2nPW1TsEQUHvnVpepcoz BsT2FtfIykitWiM2+PZXcJ4mRXH4j8DSoe7MIgOAb6pEPGxyz5GAdpaPJpuHBAPTNi KCpTp6F11eUsc1RCPW7VcNBmFmlbo+N71sogJ9PjO/ElyKpEMn2vAC6C13Oiiv60R/ eoVM5u2dMVDFgHeGzm/58EQorlH/qJUxoSuGDcpIh/TOgXrXz3/auiZhPSulPRq/KV IwgBoJysWYW3A== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2962D120960; Sat, 7 May 2022 12:06:11 -0400 (EDT) In-Reply-To: <20220507100605.B7CA7C051FF@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 7 May 2022 06:06:05 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289403 Archived-At: > - (let ((modified (make-symbol "modified"))) > + (let ((modified (make-symbol "modified")) > + (tick (make-symbol "tick"))) > `(let* ((,modified (buffer-modified-p)) > + (,tick (buffer-modified-tick)) > (buffer-undo-list t) > (inhibit-read-only t) > (inhibit-modification-hooks t)) > (unwind-protect > (progn > ,@body) > + ;; We restore the buffer tick count, too, because otherwise > + ;; we'll trigger a new auto-save. > + (internal--set-buffer-modified-tick ,tick) > (unless ,modified > (restore-buffer-modified-p nil)))))) BTW, I wonder if the auto-save mechanism should use the CHARS_MODIFF ticks instead? Stefan