unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 48ac40e60e: ; Fix last change.
Date: Sun, 14 Aug 2022 14:16:02 -0400	[thread overview]
Message-ID: <jwvtu6elmxx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220814175134.47827C09BFD@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sun, 14 Aug 2022 13:51:34 -0400 (EDT)")

Eli Zaretskii [2022-08-14 13:51:34] wrote:
> diff --git a/doc/lispref/functions.texi b/doc/lispref/functions.texi
> index 8c6328b440..e140998d65 100644
> --- a/doc/lispref/functions.texi
> +++ b/doc/lispref/functions.texi
> @@ -219,8 +219,10 @@ function.  For example:
>  
>  @defun compiled-function-p object
>  This function returns @code{t} if @var{object} is a function object
> -that was either byte-compiled (@pxref{Byte Compilation}) or
> -natively-compiled (@pxref{Native Compilation}).
> +that was either built-in (a.k.a.@: ``primitive'', @pxref{What is a
> +Function}), or byte-compiled (@pxref{Byte Compilation}), or
> +natively-compiled (@pxref{Native Compilation}), or a function loaded
> +from a dynamic module (@pxref{Dynamic Modules}).
>  @end defun
>  
>  @defun subr-arity subr
> diff --git a/etc/NEWS b/etc/NEWS
> index 0788b94da2..c982684d3a 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2573,8 +2573,9 @@ patcomp.el, pc-mode.el, pc-select.el, s-region.el, and sregex.el.
>  
>  +++
>  ** New function 'compiled-function-p'.
> -This returns non-nil if its argument is either a byte-compiled or a
> -natively-compiled function object.
> +This returns non-nil if its argument is either a built-in, or a
> +byte-compiled, or a natively-compiled function object, or a function
> +loaded from a dynamic module.

Funny: I find this rather hard to understand compared to my
original wording.  E.g. a reader might wonder what other cases there
could be and why they don't return non-nil.

IOW, I prefer an "intentional" description over the "extensional" one
you installed.  E.g. it's more useful when faced with a new
function type.


        Stefan




       reply	other threads:[~2022-08-14 18:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166049949398.16955.13217655219158269477@vcs2.savannah.gnu.org>
     [not found] ` <20220814175134.47827C09BFD@vcs2.savannah.gnu.org>
2022-08-14 18:16   ` Stefan Monnier [this message]
2022-08-14 18:31     ` master 48ac40e60e: ; Fix last change Eli Zaretskii
2022-08-14 18:42       ` Stefan Monnier
2022-08-14 18:46         ` Eli Zaretskii
2022-08-14 18:56           ` Lars Ingebrigtsen
2022-08-14 19:15             ` Eli Zaretskii
2022-08-14 19:23               ` Lars Ingebrigtsen
2022-08-15  2:23                 ` Eli Zaretskii
2022-08-15  4:30                   ` Lars Ingebrigtsen
2022-08-15 11:30                     ` Eli Zaretskii
2022-08-15  2:37           ` Stefan Monnier
2022-08-15 11:20             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtu6elmxx.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).