From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 48ac40e60e: ; Fix last change. Date: Sun, 14 Aug 2022 14:16:02 -0400 Message-ID: References: <166049949398.16955.13217655219158269477@vcs2.savannah.gnu.org> <20220814175134.47827C09BFD@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 14 20:18:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNICB-0002Js-Hk for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Aug 2022 20:18:43 +0200 Original-Received: from localhost ([::1]:45472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNICA-0006q2-EB for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Aug 2022 14:18:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNI9p-0005te-LA for emacs-devel@gnu.org; Sun, 14 Aug 2022 14:16:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNI9n-00025x-6e; Sun, 14 Aug 2022 14:16:16 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6433644093D; Sun, 14 Aug 2022 14:16:09 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E221D44091E; Sun, 14 Aug 2022 14:16:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660500963; bh=AiyDeNKwmMHBKzZgxv8pUmph21eQ5MA9YnlytoV4gV0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Vh0JILWSgHbBvrO9Jc2lwLpCd/kRPRFvora15Z2UpPQjYXlIttusfOTOxG3ymM4pF uO/XYtJ65xHNvhNEugXd96GRxlch79loQpKaAGJR3EbPA1UfTMsR6VDpRo0KH9+3p7 vnsqieXDNMa8Tgb7UoMcvZtN7gRSd8A624Pg4SN0sRXme11PTlKUpXoMzfiuKhMYjN IcWHR3q6xsWCpflIblKPNUAj+wCTqgNnz7+t9Ihn3aSkvaBt6+P6vpN5FESVzih0D0 IlHBB7crcNjeLGsVzTf2Y/boZfPUOUs638LZ2K06ySZhosnbLFQbCuVUgWpu3oUC0c q55MveXgLTevA== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 98BE5120172; Sun, 14 Aug 2022 14:16:03 -0400 (EDT) In-Reply-To: <20220814175134.47827C09BFD@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sun, 14 Aug 2022 13:51:34 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293457 Archived-At: Eli Zaretskii [2022-08-14 13:51:34] wrote: > diff --git a/doc/lispref/functions.texi b/doc/lispref/functions.texi > index 8c6328b440..e140998d65 100644 > --- a/doc/lispref/functions.texi > +++ b/doc/lispref/functions.texi > @@ -219,8 +219,10 @@ function. For example: > > @defun compiled-function-p object > This function returns @code{t} if @var{object} is a function object > -that was either byte-compiled (@pxref{Byte Compilation}) or > -natively-compiled (@pxref{Native Compilation}). > +that was either built-in (a.k.a.@: ``primitive'', @pxref{What is a > +Function}), or byte-compiled (@pxref{Byte Compilation}), or > +natively-compiled (@pxref{Native Compilation}), or a function loaded > +from a dynamic module (@pxref{Dynamic Modules}). > @end defun > > @defun subr-arity subr > diff --git a/etc/NEWS b/etc/NEWS > index 0788b94da2..c982684d3a 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -2573,8 +2573,9 @@ patcomp.el, pc-mode.el, pc-select.el, s-region.el, and sregex.el. > > +++ > ** New function 'compiled-function-p'. > -This returns non-nil if its argument is either a byte-compiled or a > -natively-compiled function object. > +This returns non-nil if its argument is either a built-in, or a > +byte-compiled, or a natively-compiled function object, or a function > +loaded from a dynamic module. Funny: I find this rather hard to understand compared to my original wording. E.g. a reader might wonder what other cases there could be and why they don't return non-nil. IOW, I prefer an "intentional" description over the "extensional" one you installed. E.g. it's more useful when faced with a new function type. Stefan