* Re: [elpa] master b59bae3 1/2: New file debbugs-reference.el [not found] ` <E1Yf7gb-0007Au-Jf@vcs.savannah.gnu.org> @ 2015-04-07 21:32 ` Stefan Monnier 2015-04-08 6:42 ` Michael Albinus 0 siblings, 1 reply; 3+ messages in thread From: Stefan Monnier @ 2015-04-07 21:32 UTC (permalink / raw) To: emacs-devel; +Cc: Michael Albinus > + (setq-local browse-url-browser-function 'debbugs-browse-url) I think this should use add-function instead of setq and it should try to only redirect to debbugs for those URLs that actually point to Debbugs sites. Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] master b59bae3 1/2: New file debbugs-reference.el 2015-04-07 21:32 ` [elpa] master b59bae3 1/2: New file debbugs-reference.el Stefan Monnier @ 2015-04-08 6:42 ` Michael Albinus 2015-04-08 14:40 ` Stefan Monnier 0 siblings, 1 reply; 3+ messages in thread From: Michael Albinus @ 2015-04-08 6:42 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: >> + (setq-local browse-url-browser-function 'debbugs-browse-url) > > I think this should use add-function instead of setq and it should try > to only redirect to debbugs for those URLs that actually point to > Debbugs sites. add-function is an advice, which I wanted to avoid. I still live in the old times, where an advice of a function was discouraged in core Emacs ... And the debbugs package is also used with Emacs 23, which doesn't know nadvice.el. I've got a help request for this, some days ago. OK, will see how to change it. > Stefan Best regards, Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] master b59bae3 1/2: New file debbugs-reference.el 2015-04-08 6:42 ` Michael Albinus @ 2015-04-08 14:40 ` Stefan Monnier 0 siblings, 0 replies; 3+ messages in thread From: Stefan Monnier @ 2015-04-08 14:40 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel > add-function is an advice, which I wanted to avoid. It's not more of an advice than add-hook is. advice-add is an advice. Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-08 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20150406140733.27546.9397@vcs.savannah.gnu.org>
[not found] ` <E1Yf7gb-0007Au-Jf@vcs.savannah.gnu.org>
2015-04-07 21:32 ` [elpa] master b59bae3 1/2: New file debbugs-reference.el Stefan Monnier
2015-04-08 6:42 ` Michael Albinus
2015-04-08 14:40 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).