* Re: master 59c343b: Don't optimize away star patterns in minibuffer file name completion
[not found] ` <20201001030717.55372209AC@vcs0.savannah.gnu.org>
@ 2020-10-01 3:40 ` Stefan Monnier
2020-10-01 4:35 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2020-10-01 3:40 UTC (permalink / raw)
To: emacs-devel; +Cc: Pip Cet
> Don't optimize away star patterns in minibuffer file name completion
Please add a matching regression test since we don't really understand
the problem enough to be sure this is the right fix.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 59c343b: Don't optimize away star patterns in minibuffer file name completion
2020-10-01 3:40 ` master 59c343b: Don't optimize away star patterns in minibuffer file name completion Stefan Monnier
@ 2020-10-01 4:35 ` Lars Ingebrigtsen
2020-10-01 13:09 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-01 4:35 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Pip Cet, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Don't optimize away star patterns in minibuffer file name completion
>
> Please add a matching regression test since we don't really understand
> the problem enough to be sure this is the right fix.
I'm not sure where to even start with adding tests for the file name
completion stuff...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 59c343b: Don't optimize away star patterns in minibuffer file name completion
2020-10-01 4:35 ` Lars Ingebrigtsen
@ 2020-10-01 13:09 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2020-10-01 13:09 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Pip Cet, emacs-devel
>>> Don't optimize away star patterns in minibuffer file name completion
>>
>> Please add a matching regression test since we don't really understand
>> the problem enough to be sure this is the right fix.
>
> I'm not sure where to even start with adding tests for the file name
> completion stuff...
There are some tests in `test/lisp/minibuffer-tests.el` which should
give you some good starting points. The test in
`test/lisp/emacs-lisp/find-func-tests.el` could also be a useful
starting point.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-01 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201001030715.1920.98667@vcs0.savannah.gnu.org>
[not found] ` <20201001030717.55372209AC@vcs0.savannah.gnu.org>
2020-10-01 3:40 ` master 59c343b: Don't optimize away star patterns in minibuffer file name completion Stefan Monnier
2020-10-01 4:35 ` Lars Ingebrigtsen
2020-10-01 13:09 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).