From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master 82c76e3: * lisp/eshell/em-cmpl.el: Try and fix bug#41423
Date: Sat, 05 Jun 2021 11:52:14 -0400 [thread overview]
Message-ID: <jwvr1hgxqfv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k0nlpff6.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 26 May 2021 18:34:37 +0100")
> 2. C-h e
> 3. ./bi TAB
>
> Before the commit in question, this gave:
>
> (metadata
> (cycle-sort-function . #[...])
> (category . file)
> (completion--unquote-requote . t))
> (#("bin/"
> 0 1 (face completions-common-part)
> 1 2 (face completions-common-part arg-end t rear-nonsticky
> (arg-end arg-begin))
> 2 3 (face (completions-first-difference)))
> . 2)
>
> And after:
>
> (metadata (completion--unquote-requote . t))
> (#("bin/" 0 4 (face (completions-common-part))) . 0)
>
> Is this expected, or should some of the old information have been
> preserved?
No, this is not expected (i.e. a regression) and having
`completions-common-part` on the whole of "bin/" seems like a bug (not
just a regression).
Stefan
prev parent reply other threads:[~2021-06-05 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210201002715.13331.49843@vcs0.savannah.gnu.org>
[not found] ` <20210201002717.273E120DF3@vcs0.savannah.gnu.org>
2021-05-26 17:34 ` master 82c76e3: * lisp/eshell/em-cmpl.el: Try and fix bug#41423 Basil L. Contovounesios
2021-06-05 15:52 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr1hgxqfv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).