From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 82c76e3: * lisp/eshell/em-cmpl.el: Try and fix bug#41423 Date: Sat, 05 Jun 2021 11:52:14 -0400 Message-ID: References: <20210201002715.13331.49843@vcs0.savannah.gnu.org> <20210201002717.273E120DF3@vcs0.savannah.gnu.org> <87k0nlpff6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 05 17:52:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpYbW-0000Em-PV for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Jun 2021 17:52:54 +0200 Original-Received: from localhost ([::1]:58120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpYbV-0001x8-EJ for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Jun 2021 11:52:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpYb0-0001D4-Sc for emacs-devel@gnu.org; Sat, 05 Jun 2021 11:52:23 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpYay-00054t-5o for emacs-devel@gnu.org; Sat, 05 Jun 2021 11:52:21 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4F8388091E; Sat, 5 Jun 2021 11:52:17 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A4A2980182; Sat, 5 Jun 2021 11:52:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622908335; bh=vc8664Hh8tbJdx85GhxlQsClxuKYWvI6QYzDFioMz9A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lvVGqlGa+0JblR7x1pgo0a/i3jIfEgS4mcqcd7q2+HKhtPz1tRKDZGB4fuEa/ZvC0 qlmR5ZGmKtdk5ZVZiwAKCnUUjw7XzeSo6gNt9+K5v9wpwcU0WefUjh5pKw7rPrlPJK Su+0UwXRsZL/FWNSjCsCChG8iwuNViLkUEA2faoI1c6QF+yb7gVY9dtHxufeTEfLN+ 6NaQb91LDQG5w1bMFHblwGWKDZSAhswi88q3rGBqhvLryFfrdMNkyZPhBY6wFZqbMV weIw6ZyHikczrcXF3x0au0t8S9yOdq7vuZ0w2ubl0usC4EZkdv/TFyURyHmsZPEPL5 /oT1qvWFUucUA== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6F9D51201CF; Sat, 5 Jun 2021 11:52:15 -0400 (EDT) In-Reply-To: <87k0nlpff6.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 26 May 2021 18:34:37 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270439 Archived-At: > 2. C-h e > 3. ./bi TAB > > Before the commit in question, this gave: > > (metadata > (cycle-sort-function . #[...]) > (category . file) > (completion--unquote-requote . t)) > (#("bin/" > 0 1 (face completions-common-part) > 1 2 (face completions-common-part arg-end t rear-nonsticky > (arg-end arg-begin)) > 2 3 (face (completions-first-difference))) > . 2) > > And after: > > (metadata (completion--unquote-requote . t)) > (#("bin/" 0 4 (face (completions-common-part))) . 0) > > Is this expected, or should some of the old information have been > preserved? No, this is not expected (i.e. a regression) and having `completions-common-part` on the whole of "bin/" seems like a bug (not just a regression). Stefan