From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master f3aa648: Make `lookup-key' understand the new key sequence syntax
Date: Tue, 19 Oct 2021 10:13:53 -0400 [thread overview]
Message-ID: <jwvr1ch3xxl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wnm9dtee.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 Oct 2021 15:40:57 +0200")
Lars Ingebrigtsen [2021-10-19 15:40:57] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think your `possibly_translate_key_sequence` should be extended to
>> cover the XEmacs format as well, And it should be exported to ELisp.
>
> lookup-key/define-key already understands that format, but mixes the
> interpretation into the code itself.
>
> (lookup-key (current-global-map) [(control x) (control f)])
> => find-file
>
> Pulling it out of the code and putting it into
> possibly_translate_key_sequence would be fine, I think.
>
>> And I'd argue it should also convert strings to vectors.
>
> Sure.
>
>> Oh and also convert [M-C-next] to [C-M-next].
>
> Uhm... I'm not sure what the impact would be...
In terms of behavior, no impact:
ELISP> (let ((map (make-sparse-keymap))) (define-key map [C-M-next] 'dummy) map)
(keymap (C-M-next . dummy))
ELISP> (let ((map (make-sparse-keymap))) (define-key map [M-C-next] 'dummy) map)
(keymap (C-M-next . dummy))
ELISP>
-- Stefan
next prev parent reply other threads:[~2021-10-19 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211019030801.23534.79581@vcs0.savannah.gnu.org>
[not found] ` <20211019030802.83DE621120@vcs0.savannah.gnu.org>
2021-10-19 12:45 ` master f3aa648: Make `lookup-key' understand the new key sequence syntax Stefan Monnier
2021-10-19 13:40 ` Lars Ingebrigtsen
2021-10-19 14:13 ` Stefan Monnier [this message]
2021-10-19 14:17 ` Lars Ingebrigtsen
2021-10-19 14:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr1ch3xxl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).