From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f3aa648: Make `lookup-key' understand the new key sequence syntax Date: Tue, 19 Oct 2021 10:13:53 -0400 Message-ID: References: <20211019030801.23534.79581@vcs0.savannah.gnu.org> <20211019030802.83DE621120@vcs0.savannah.gnu.org> <87wnm9dtee.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28375"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 19 16:16:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcpuQ-0007B1-Vr for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 16:16:07 +0200 Original-Received: from localhost ([::1]:53868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcpuP-0000Or-46 for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 10:16:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpsP-0006Lm-5e for emacs-devel@gnu.org; Tue, 19 Oct 2021 10:14:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpsL-0005nH-RY for emacs-devel@gnu.org; Tue, 19 Oct 2021 10:13:59 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BAA19440CF6; Tue, 19 Oct 2021 10:13:55 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6CC32440CDD; Tue, 19 Oct 2021 10:13:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634652834; bh=bBcIJ0qNZdxnn90X9RZ1mgd3/CvZoRHF+w8WRmJyCeg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=H9hhoLVextBNDBJFVJSb2/0DVL3j+nmFDXQlgZxB2OR+NYPKGqY/XRDpo5WeI/qWc w5xqR/NIN2nbcOogRPXSS2zQ2VCfD9iTcZAb6je4BA0YrF1mvyb60WbIUFLwrNyp6W yElor+9MvlGp876t6I5OpvUolRzQcQhqoJNZT7dPUc7VpMITCeV8gpk67BYgnoFHrT Fw67z8y7Y3+yvsHbgrLU9tdH/fXeeOvQOpPld5vz9ZZ0HBaA9QQAl8Xe/avv/VgtMJ GxgAfa664yc8edFPLprUkbIR0VetzN72n94TJEqzH8xHgOLPrELXpjFqIrKO0hpAU6 wJqQGrAhpGGng== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4059B120315; Tue, 19 Oct 2021 10:13:54 -0400 (EDT) In-Reply-To: <87wnm9dtee.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 Oct 2021 15:40:57 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277369 Archived-At: Lars Ingebrigtsen [2021-10-19 15:40:57] wrote: > Stefan Monnier writes: >> I think your `possibly_translate_key_sequence` should be extended to >> cover the XEmacs format as well, And it should be exported to ELisp. > > lookup-key/define-key already understands that format, but mixes the > interpretation into the code itself. > > (lookup-key (current-global-map) [(control x) (control f)]) > => find-file > > Pulling it out of the code and putting it into > possibly_translate_key_sequence would be fine, I think. > >> And I'd argue it should also convert strings to vectors. > > Sure. > >> Oh and also convert [M-C-next] to [C-M-next]. > > Uhm... I'm not sure what the impact would be... In terms of behavior, no impact: ELISP> (let ((map (make-sparse-keymap))) (define-key map [C-M-next] 'dummy) map) (keymap (C-M-next . dummy)) ELISP> (let ((map (make-sparse-keymap))) (define-key map [M-C-next] 'dummy) map) (keymap (C-M-next . dummy)) ELISP> -- Stefan