* log-view.el calls non-existent function vc-version-diff
@ 2007-10-13 13:21 Chris Moore
2007-10-13 17:44 ` Dan Nicolaescu
0 siblings, 1 reply; 3+ messages in thread
From: Chris Moore @ 2007-10-13 13:21 UTC (permalink / raw)
To: emacs-pretest-bug
The only 2 references to vc-version-diff in the whole lisp/ tree are:
./log-view.el:(autoload 'vc-version-diff "vc")
./log-view.el: (vc-version-diff (log-view-current-file) to fr)))
So generating a log of a controlled file ("C-x v l") and asking for a
diff ("d") errors:
Debugger entered--Lisp error: (error "Autoloading failed to define
function vc-version-diff")
vc-version-diff("/home/chris/programs/emacs/lisp/log-view.el" "1.45" "1.46")
log-view-diff(2537 2537)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: log-view.el calls non-existent function vc-version-diff
2007-10-13 13:21 log-view.el calls non-existent function vc-version-diff Chris Moore
@ 2007-10-13 17:44 ` Dan Nicolaescu
2007-10-14 2:07 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Dan Nicolaescu @ 2007-10-13 17:44 UTC (permalink / raw)
To: Chris Moore; +Cc: Eric S. Raymond, emacs-pretest-bug
"Chris Moore" <christopher.ian.moore@gmail.com> writes:
> The only 2 references to vc-version-diff in the whole lisp/ tree are:
>
> ./log-view.el:(autoload 'vc-version-diff "vc")
> ./log-view.el: (vc-version-diff (log-view-current-file) to fr)))
It seems that it should be changed to call vc-history-diff.
But vc-history-diff takes a `backend' parameter. But it computes the
backend in the code anyway...
ESR, can you please say what is your intention with that function?
Should it just lose the `backend' parameter?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: log-view.el calls non-existent function vc-version-diff
2007-10-13 17:44 ` Dan Nicolaescu
@ 2007-10-14 2:07 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2007-10-14 2:07 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: Eric S. Raymond, emacs-pretest-bug, Chris Moore
>> The only 2 references to vc-version-diff in the whole lisp/ tree are:
>>
>> ./log-view.el:(autoload 'vc-version-diff "vc")
>> ./log-view.el: (vc-version-diff (log-view-current-file) to fr)))
> It seems that it should be changed to call vc-history-diff.
> But vc-history-diff takes a `backend' parameter. But it computes the
> backend in the code anyway...
> ESR, can you please say what is your intention with that function?
> Should it just lose the `backend' parameter?
In any case, vc.el should provide a backward compatibility definition of
vc-version-diff (and mark it obsolete).
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-14 2:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-13 13:21 log-view.el calls non-existent function vc-version-diff Chris Moore
2007-10-13 17:44 ` Dan Nicolaescu
2007-10-14 2:07 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).