[drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Richard Stallman]

This is a real bug.  Would someone please fix it, then ack?


From: "Drew Adams" <drew.adams@oracle.com>
To: "Bug-Gnu-Emacs" <bug-gnu-emacs@gnu.org>
Date: Sun, 25 Nov 2007 00:17:10 -0800
Message-ID: <DHEEKFAFJEFOJHLCFPFDKEHPCCAA.drew.adams@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Subject: use-file-dialog should not apply to mouse in *Completions*

The doc string of `use-file-dialog' says "it applies to commands from
menus and tool bar buttons". That suggests that it does not apply to
command names that you click mouse-2 on in *Completions* -
e.g. `find-file-other-window' from `M-x'. However, that's what
happens: if the value is non-nil, then the file dialog box pops up. It
should not.

Please fix the variable in accordance with its doc string (menus and
tool-bar buttons only). If it's thought that users should be also able
to specify the file dialog box for *Completions* (to keep using the
mouse to pick the file), then there should be another option for that
- it's too common to want a file dialog box for menus and tool-bar
buttons but not for *Completions*.




In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
 of 2007-06-02 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Jan Djärv]

This does not happen on X11, must be an W32 only bug.

	Jan D.


Richard Stallman skrev:
> This is a real bug.  Would someone please fix it, then ack?
> 
> 
> From: "Drew Adams" <drew.adams@oracle.com>
> To: "Bug-Gnu-Emacs" <bug-gnu-emacs@gnu.org>
> Date: Sun, 25 Nov 2007 00:17:10 -0800
> Message-ID: <DHEEKFAFJEFOJHLCFPFDKEHPCCAA.drew.adams@oracle.com>
> MIME-Version: 1.0
> Content-Type: text/plain;
> 	charset="iso-8859-1"
> Subject: use-file-dialog should not apply to mouse in *Completions*
> 
> The doc string of `use-file-dialog' says "it applies to commands from
> menus and tool bar buttons". That suggests that it does not apply to
> command names that you click mouse-2 on in *Completions* -
> e.g. `find-file-other-window' from `M-x'. However, that's what
> happens: if the value is non-nil, then the file dialog box pops up. It
> should not.
> 
> Please fix the variable in accordance with its doc string (menus and
> tool-bar buttons only). If it's thought that users should be also able
> to specify the file dialog box for *Completions* (to keep using the
> mouse to pick the file), then there should be another option for that
> - it's too common to want a file dialog box for menus and tool-bar
> buttons but not for *Completions*.
> 
> 
> 
> 
> In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
>  of 2007-06-02 on RELEASE
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Jason Rumney]

Jan Djärv wrote:
> This does not happen on X11, must be an W32 only bug.

It does happen on X11 for me.

1. M-x find TAB

2. Click on find-file or find-file-other-window with the mouse.


However, I think it is the documentation that needs fixing here to match
the documentation of read-file-name.

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Jason Rumney]

Jason Rumney wrote:
> However, I think it is the documentation that needs fixing here to match
> the documentation of read-file-name.
>   

I propose the following change to make the documentation clearer for
this variable:


*** fns.c.~1.424.2.3.~    2007-09-24 16:28:57.750000000 +0100
--- fns.c    2007-12-03 09:34:13.187500000 +0000
***************
*** 5827,5836 ****
    use_dialog_box = 1;
 
    DEFVAR_BOOL ("use-file-dialog", &use_file_dialog,
!     doc: /* *Non-nil means mouse commands use a file dialog to ask for
files.
! This applies to commands from menus and tool bar buttons.  The value of
! `use-dialog-box' takes precedence over this variable, so a file dialog
is only
! used if both `use-dialog-box' and this variable are non-nil.  */);
    use_file_dialog = 1;
 
    defsubr (&Sidentity);
--- 5827,5838 ----
    use_dialog_box = 1;
 
    DEFVAR_BOOL ("use-file-dialog", &use_file_dialog,
!     doc: /* *Non-nil means mouse commands use a file dialog to ask for
! files.  This applies to commands from menus and tool bar buttons even
! when they are initiated from the keyboard.  The value of
! `use-dialog-box' takes precedence over this variable, so a file dialog
! is only used if both `use-dialog-box' and this variable are
! non-nil.  */);
    use_file_dialog = 1;
 
    defsubr (&Sidentity);

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Andreas Schwab]

Jason Rumney <jasonr@gnu.org> writes:

>     DEFVAR_BOOL ("use-file-dialog", &use_file_dialog,
> !     doc: /* *Non-nil means mouse commands use a file dialog to ask for
> ! files.  This applies to commands from menus and tool bar buttons even

The first line should always be a complete sentence.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Jason Rumney]

Andreas Schwab wrote:
> Jason Rumney <jasonr@gnu.org> writes:
>
>   
>>     DEFVAR_BOOL ("use-file-dialog", &use_file_dialog,
>> !     doc: /* *Non-nil means mouse commands use a file dialog to ask for
>> ! files.  This applies to commands from menus and tool bar buttons even
>>     
>
> The first line should always be a complete sentence.
>   

It looks like I got caught out by autofill there. I didn't intend to
change that line.

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Richard Stallman]

    However, I think it is the documentation that needs fixing here to match
    the documentation of read-file-name.

This is a real bug; the code needs to be changed.

`read-file-name' is supposed to use the file dialog when you invoke
the command with the mouse.  The point is that choosing a completion
with the mouse, inside M-x, should not count as "invoking the command
with the mouse".

That is what needs to be changed.  Would someone fix that and ack?

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Stefan Monnier]

>     However, I think it is the documentation that needs fixing here to match
>     the documentation of read-file-name.

> This is a real bug; the code needs to be changed.

> `read-file-name' is supposed to use the file dialog when you invoke
> the command with the mouse.  The point is that choosing a completion
> with the mouse, inside M-x, should not count as "invoking the command
> with the mouse".

> That is what needs to be changed.  Would someone fix that and ack?

I think in this case both behaviors can make sense.  It's not clear to
me that one is better than the other.  Clearly, the M-x had to be typed,
but the user had to switch to the mouse in order to click the
`find-file' completion, so maybe she wants to keep using the mouse
rather than switch back to the keyboard.


        Stefan

RE: [drew.adams@oracle.com: use-file-dialog should not apply tomouse in *Completions*]

[Drew Adams]

> >     However, I think it is the documentation that needs fixing 
> >     here to match the documentation of read-file-name.
> 
> > This is a real bug; the code needs to be changed.
> 
> > `read-file-name' is supposed to use the file dialog when you invoke
> > the command with the mouse.  The point is that choosing a completion
> > with the mouse, inside M-x, should not count as "invoking the command
> > with the mouse".
> 
> > That is what needs to be changed.  Would someone fix that and ack?
> 
> I think in this case both behaviors can make sense.  It's not clear to
> me that one is better than the other.  Clearly, the M-x had to be typed,
> but the user had to switch to the mouse in order to click the
> `find-file' completion, so maybe she wants to keep using the mouse
> rather than switch back to the keyboard.

That's why the bug report included this:

>> If it's thought that users should be also able
>> to specify the file dialog box for *Completions* (to keep using the
>> mouse to pick the file), then there should be another option for that
>> - it's too common to want a file dialog box for menus and tool-bar
>> buttons but not for *Completions*.

Re: [drew.adams@oracle.com: use-file-dialog should not apply tomouse in *Completions*]

[Stefan Monnier]

>>> - it's too common to want a file dialog box for menus and tool-bar
>>> buttons but not for *Completions*.

I highly doubt the "common".


        Stefan

Re: [drew.adams@oracle.com: use-file-dialog should not apply tomouse in *Completions*]

[martin rudalics]

> I highly doubt the "common".

... they are a common nuisance.

RE: [drew.adams@oracle.com: use-file-dialog should not apply tomouse in *Completions*]

[Drew Adams]

> >>> - it's too common to want a file dialog box for menus and tool-bar
> >>> buttons but not for *Completions*.
>
> I highly doubt the "common".

I said "too common", not "common" or even "more common". Too common for the
current (bugged, IMO) behavior to be the only one available. Either the
other behavior should be the only one available, or an option should let you
choose.

However, wrt common or more common (since you bring it up): I do think it is
more common to want to use the mouse in a consistent way with completion.

If you are using completion (e.g. M-x), and the command you pick (e.g.
`find-file-other-window') also uses completion, the fact that you choose to
pick the command name with the mouse might suggest that you would also
choose to pick the file name with the mouse (in *Completions*). I expect it
to be less common for someone to want to click mouse-2 on
`file-file-other-window' but not want to click mouse-2 on the file name and
instead dig it out of the file dialog box.

But who knows? Users are various. Add yet another option, if you like.

Re: [drew.adams@oracle.com: use-file-dialog should not apply to mouse in *Completions*]

[Richard Stallman]

    but the user had to switch to the mouse in order to click the
    `find-file' completion, so maybe she wants to keep using the mouse
    rather than switch back to the keyboard.

I expect users to think of this as a keyboard
command, and expect the keyboard behavior.