* Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
[not found] ` <E1aZXmJ-00041n-22@vcs.savannah.gnu.org>
@ 2016-02-27 14:23 ` Stefan Monnier
2016-02-27 15:02 ` Kaushal Modi
2016-02-28 10:23 ` Richard Stallman
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2016-02-27 14:23 UTC (permalink / raw)
To: emacs-devel; +Cc: Leo Liu
> * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
One more time: please always include some kind of explanation when you
revert code. E.g. a bug# or something.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
2016-02-27 14:23 ` [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change Stefan Monnier
@ 2016-02-27 15:02 ` Kaushal Modi
2016-02-27 17:23 ` Leo Liu
2016-02-28 10:23 ` Richard Stallman
1 sibling, 1 reply; 5+ messages in thread
From: Kaushal Modi @ 2016-02-27 15:02 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Oleh Krehel, Leo Liu, emacs-devel@gnu.org
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
FWIW I actually liked the indent change that was put in the first place. If
you look at the explanation in that commit, it makes sense why that indent
change was done.
I did not understand why it was reverted in this recent commit.
Kaushal
On Saturday, February 27, 2016, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> > * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent
> change.
>
> One more time: please always include some kind of explanation when you
> revert code. E.g. a bug# or something.
>
>
> Stefan
>
>
--
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 892 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
2016-02-27 15:02 ` Kaushal Modi
@ 2016-02-27 17:23 ` Leo Liu
0 siblings, 0 replies; 5+ messages in thread
From: Leo Liu @ 2016-02-27 17:23 UTC (permalink / raw)
To: emacs-devel
On 2016-02-27 10:02 -0500, Kaushal Modi wrote:
> FWIW I actually liked the indent change that was put in the first place. If
> you look at the explanation in that commit, it makes sense why that indent
> change was done.
Sorry I can't check the explanation now since I lost connection to my
server which hosts the emacs repo. Could you post the explanation?
> I did not understand why it was reverted in this recent commit.
>
> Kaushal
Could you show me a code example that has bad indentation that (indent
3) fixes? Adding (indent 3) gives bad indentation to some previously
well-indented code. The previous indentation setting seems more
flexible.
Leo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
2016-02-27 14:23 ` [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change Stefan Monnier
2016-02-27 15:02 ` Kaushal Modi
@ 2016-02-28 10:23 ` Richard Stallman
2016-02-28 16:25 ` Stefan Monnier
1 sibling, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2016-02-28 10:23 UTC (permalink / raw)
To: Stefan Monnier; +Cc: sdl.web, emacs-devel
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> > * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
> One more time: please always include some kind of explanation when you
> revert code. E.g. a bug# or something.
Even in this sort of case, I think the best place for the explanation
is in the source file, where the reverted code was.
--
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
2016-02-28 10:23 ` Richard Stallman
@ 2016-02-28 16:25 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2016-02-28 16:25 UTC (permalink / raw)
To: Richard Stallman; +Cc: sdl.web, emacs-devel
> Even in this sort of case, I think the best place for the explanation
> is in the source file, where the reverted code was.
Agreed. But as a first step "somewhere" is better than "nowhere".
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-28 16:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20160227055054.15422.83807@vcs.savannah.gnu.org>
[not found] ` <E1aZXmJ-00041n-22@vcs.savannah.gnu.org>
2016-02-27 14:23 ` [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change Stefan Monnier
2016-02-27 15:02 ` Kaushal Modi
2016-02-27 17:23 ` Leo Liu
2016-02-28 10:23 ` Richard Stallman
2016-02-28 16:25 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).