unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Suggestion: Show candidates list immediately in completing-read-multiple
@ 2020-04-23 16:49 akater
  2020-04-24 15:24 ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: akater @ 2020-04-23 16:49 UTC (permalink / raw)
  To: emacs-devel

With completing-read, completion candidates appear immediately. With
crm, user has to press TAB for candidates to appear. I find this
inconsistent and suggest to make the list of candidates appear
immediately in completing-read-multiple.

To give an example, the following change in Org-mode

#+begin_src diff
--- a/lisp/org/org-agenda.el
+++ b/lisp/org/org-agenda.el
@@ -4774,8 +4774,11 @@
                                                 (nth (1- arg) kwds))))
       (when (equal arg '(4))
         (setq org-select-this-todo-keyword
-              (completing-read "Keyword (or KWD1|K2D2|...): "
-                               (mapcar #'list kwds) nil nil)))
+              (mapconcat #'identity
+                         (completing-read-multiple
+                          "Keyword (or KWD1|KWD2|...): "
+                          (mapcar #'list kwds) nil nil)
+                         "|")))
       (and (equal 0 arg) (setq org-select-this-todo-keyword nil))
       (org-compile-prefix-format 'todo)
       (org-set-sorting-strategy 'todo)
#+end_src

makes it necessary to hit TAB where one didn't have to. I think the
change is reasonable but I'd rather suggest to apply the patch if it
didn't alter the user experience as described.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Suggestion: Show candidates list immediately in completing-read-multiple
  2020-04-23 16:49 Suggestion: Show candidates list immediately in completing-read-multiple akater
@ 2020-04-24 15:24 ` Stefan Monnier
  2020-04-27 20:41   ` Suggestion: Support more arbitrary separators " akater
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2020-04-24 15:24 UTC (permalink / raw)
  To: akater; +Cc: emacs-devel

> With completing-read, completion candidates appear immediately.

Not in `emacs -Q`, so please clarify what it is you're using that makes
the candidates appear.  Without this info, it will be difficult to
figure out how to change the behavior w.r.t crm.

FWIW, `icomplete-mode` seems to work fine with crm.


        Stefan




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Suggestion: Support more arbitrary separators in completing-read-multiple
  2020-04-24 15:24 ` Stefan Monnier
@ 2020-04-27 20:41   ` akater
  0 siblings, 0 replies; 3+ messages in thread
From: akater @ 2020-04-27 20:41 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> With completing-read, completion candidates appear immediately.
>
> Not in `emacs -Q`, so please clarify what it is you're using that makes
> the candidates appear.  Without this info, it will be difficult to
> figure out how to change the behavior w.r.t crm.
>
> FWIW, `icomplete-mode` seems to work fine with crm.
>
>
>         Stefan

You're right.  I should have checked with `emacs -Q`.  I'm using helm;
one of maintainers apparently misunderstood that it's helm that behaves
inconsistently.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-27 20:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 16:49 Suggestion: Show candidates list immediately in completing-read-multiple akater
2020-04-24 15:24 ` Stefan Monnier
2020-04-27 20:41   ` Suggestion: Support more arbitrary separators " akater

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).