From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-27 30a7ee5: Fix Arabic shaping when eww/shr fill the text to be rendered
Date: Fri, 05 Jun 2020 09:58:57 -0400 [thread overview]
Message-ID: <jwvpnadsjjn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200605075724.3C52120A26@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 5 Jun 2020 03:57:23 -0400 (EDT)")
> Fix Arabic shaping when eww/shr fill the text to be rendered
> * src/hbfont.c (hbfont_shape): Don't use DIRECTION if the current
> buffer has bidi reordering disabled. (Bug#41005)
[...]
> - if (!NILP (direction))
> + if (!NILP (direction)
> + /* If they bind bidi-display-reordering to nil, the DIRECTION
> + they provide is meaningless, and we should let HarfBuzz guess
> + the real direction. */
> + && !NILP (BVAR (current_buffer, bidi_display_reordering)))
Hmm... so indeed I see that SHR binds `bidi-display-reordering`.
Isn't that a problem, since its docstring says:
[...]
Setting this to nil is intended for use in debugging the display code.
[...]
Can we change SHR so it doesn't bind this var?
Stefan
next parent reply other threads:[~2020-06-05 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200605075722.16213.57047@vcs0.savannah.gnu.org>
[not found] ` <20200605075724.3C52120A26@vcs0.savannah.gnu.org>
2020-06-05 13:58 ` Stefan Monnier [this message]
2020-06-05 14:20 ` emacs-27 30a7ee5: Fix Arabic shaping when eww/shr fill the text to be rendered Eli Zaretskii
2020-06-05 15:20 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpnadsjjn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).