From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-27 30a7ee5: Fix Arabic shaping when eww/shr fill the text to be rendered Date: Fri, 05 Jun 2020 09:58:57 -0400 Message-ID: References: <20200605075722.16213.57047@vcs0.savannah.gnu.org> <20200605075724.3C52120A26@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="60845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 05 15:59:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhCsj-000Fhe-PI for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 15:59:37 +0200 Original-Received: from localhost ([::1]:37004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhCsi-0006e5-Sk for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 09:59:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhCsD-00069U-UC for emacs-devel@gnu.org; Fri, 05 Jun 2020 09:59:05 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhCsC-0003FV-HB; Fri, 05 Jun 2020 09:59:05 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 29E2D1004F2; Fri, 5 Jun 2020 09:59:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4DB8E10031F; Fri, 5 Jun 2020 09:58:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1591365539; bh=RGcW/mXC8/vg6BcJ0/YpJIHZkbl0j7OnxA0TINcC17Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QWrwNIyEctl1+o6qsLRF9m3ZoWgvhpZP2dveMDfntnsEOdip2F362UdWnwSQHFiAm yeiQlz30LmJ2XjG0O93kx3FoXxLk9sAVKXOd/M1LgiSc+qCk7FB6tpTdU6yTk80Qrf F6pojdjcn0W5Zpb/3zu9PahKX4ij8ThCsp102jwVbVPjAnlJWI69SfR+Rj5fc6T6rs WgxZV6A/B60eHT/wHNJyuuJ0QQYn5NLIz/8bl/UUHC1oOhmKcSkssH4ERfm9T34tGH dt/bSRzZP3+vGiFaCLSspo0egAsHyL2UuVgcIBx2LSnRzqWi6kVF085yV9vyd8P0An kpubAEZnxztFQ== Original-Received: from alfajor (unknown [157.52.17.179]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0BE6D121299; Fri, 5 Jun 2020 09:58:58 -0400 (EDT) In-Reply-To: <20200605075724.3C52120A26@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 5 Jun 2020 03:57:23 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/05 08:44:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251898 Archived-At: > Fix Arabic shaping when eww/shr fill the text to be rendered > * src/hbfont.c (hbfont_shape): Don't use DIRECTION if the current > buffer has bidi reordering disabled. (Bug#41005) [...] > - if (!NILP (direction)) > + if (!NILP (direction) > + /* If they bind bidi-display-reordering to nil, the DIRECTION > + they provide is meaningless, and we should let HarfBuzz guess > + the real direction. */ > + && !NILP (BVAR (current_buffer, bidi_display_reordering))) Hmm... so indeed I see that SHR binds `bidi-display-reordering`. Isn't that a problem, since its docstring says: [...] Setting this to nil is intended for use in debugging the display code. [...] Can we change SHR so it doesn't bind this var? Stefan