* Re: master e2ee646b162: cl-defsubst: Use static scoping for args
[not found] ` <20230623153722.553F8C1193B@vcs2.savannah.gnu.org>
@ 2023-06-27 16:40 ` Michael Albinus
2023-06-27 20:28 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2023-06-27 16:40 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
Hi,
> branch: master
> commit e2ee646b162b87e832c8032b9d90577bd21f21f8
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> cl-defsubst: Use static scoping for args
>
> * lisp/emacs-lisp/cl-macs.el (cl--slet): New function, partly extracted
> from `cl--slet*`.
> (cl--slet*): Use it.
> (cl--defsubst-expand): Use it to fix bug#47552.
>
> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-defstruct-dynbound-label):
> New test.
This breaks the tests:
--8<---------------cut here---------------start------------->8---
# make -C test cl-macs-tests
make: Entering directory '/home/albinus/src/emacs/test'
make[1]: Entering directory '/home/albinus/src/emacs/test'
ELC lisp/emacs-lisp/cl-macs-tests.elc
In toplevel form:
lisp/emacs-lisp/cl-macs-tests.el:815:39: Warning: Lexical argument shadows the dynamic variable cl--test-a
lisp/emacs-lisp/cl-macs-tests.el:816:45: Error: symbol-value cannot use lexical var `cl--test-a'
make[1]: *** [Makefile:159: lisp/emacs-lisp/cl-macs-tests.elc] Error 1
make[1]: Leaving directory '/home/albinus/src/emacs/test'
make: *** [Makefile:247: lisp/emacs-lisp/cl-macs-tests] Error 2
make: Leaving directory '/home/albinus/src/emacs/test'
--8<---------------cut here---------------end--------------->8---
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master e2ee646b162: cl-defsubst: Use static scoping for args
2023-06-27 16:40 ` master e2ee646b162: cl-defsubst: Use static scoping for args Michael Albinus
@ 2023-06-27 20:28 ` Stefan Monnier
2023-06-28 7:19 ` Michael Albinus
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2023-06-27 20:28 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> This breaks the tests:
>
> --8<---------------cut here---------------start------------->8---
> # make -C test cl-macs-tests
> make: Entering directory '/home/albinus/src/emacs/test'
> make[1]: Entering directory '/home/albinus/src/emacs/test'
> ELC lisp/emacs-lisp/cl-macs-tests.elc
>
> In toplevel form:
> lisp/emacs-lisp/cl-macs-tests.el:815:39: Warning: Lexical argument shadows
> the dynamic variable cl--test-a
> lisp/emacs-lisp/cl-macs-tests.el:816:45: Error: symbol-value cannot use lexical var `cl--test-a'
> make[1]: *** [Makefile:159: lisp/emacs-lisp/cl-macs-tests.elc] Error 1
> make[1]: Leaving directory '/home/albinus/src/emacs/test'
> make: *** [Makefile:247: lisp/emacs-lisp/cl-macs-tests] Error 2
> make: Leaving directory '/home/albinus/src/emacs/test'
> --8<---------------cut here---------------end--------------->8---
Indeed, thanks. Actually that error should have been a warning.
I believe it is now fixed on `master`. I also silenced the warnings,
while at it.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master e2ee646b162: cl-defsubst: Use static scoping for args
2023-06-27 20:28 ` Stefan Monnier
@ 2023-06-28 7:19 ` Michael Albinus
0 siblings, 0 replies; 3+ messages in thread
From: Michael Albinus @ 2023-06-28 7:19 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,
> I believe it is now fixed on `master`. I also silenced the warnings,
> while at it.
Thanks.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-28 7:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <168753464201.6199.7980223768074850748@vcs2.savannah.gnu.org>
[not found] ` <20230623153722.553F8C1193B@vcs2.savannah.gnu.org>
2023-06-27 16:40 ` master e2ee646b162: cl-defsubst: Use static scoping for args Michael Albinus
2023-06-27 20:28 ` Stefan Monnier
2023-06-28 7:19 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).