* gui_insert_glyphs in xdisp.c
@ 2020-10-14 0:43 Akira Kyle
2020-10-14 14:01 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Akira Kyle @ 2020-10-14 0:43 UTC (permalink / raw)
To: emacs-devel
I spent the past half hour trying to figure out where this
function gets called to no avail. It seems to be a part of struct
redisplay_interface but I can't seem to find anywhere it gets
called. I also haven't been able to observe this function being
called when running emacs. Is this dead code?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: gui_insert_glyphs in xdisp.c
2020-10-14 0:43 gui_insert_glyphs in xdisp.c Akira Kyle
@ 2020-10-14 14:01 ` Eli Zaretskii
2020-10-14 19:15 ` Akira Kyle
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2020-10-14 14:01 UTC (permalink / raw)
To: Akira Kyle; +Cc: emacs-devel
> From: Akira Kyle <ak@akirakyle.com>
> Date: Tue, 13 Oct 2020 18:43:19 -0600
>
> I spent the past half hour trying to figure out where this
> function gets called to no avail. It seems to be a part of struct
> redisplay_interface but I can't seem to find anywhere it gets
> called. I also haven't been able to observe this function being
> called when running emacs. Is this dead code?
The calls to this function were removed from the GUI display code when
we deleted the "direct output for insert" redisplay optimization.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: gui_insert_glyphs in xdisp.c
2020-10-14 14:01 ` Eli Zaretskii
@ 2020-10-14 19:15 ` Akira Kyle
2020-10-15 13:35 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Akira Kyle @ 2020-10-14 19:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On Wed, Oct 14, 2020 at 08:01 AM, Eli Zaretskii <eliz@gnu.org>
wrote:
>> I spent the past half hour trying to figure out where this
>> function gets called to no avail. It seems to be a part of
>> struct
>> redisplay_interface but I can't seem to find anywhere it gets
>> called. I also haven't been able to observe this function being
>> called when running emacs. Is this dead code?
>
> The calls to this function were removed from the GUI display
> code when
> we deleted the "direct output for insert" redisplay
> optimization.
Thanks! Then I assume this was kept around in case someone in the
future wanted to utilize that part of the redisplay_interface?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: gui_insert_glyphs in xdisp.c
2020-10-14 19:15 ` Akira Kyle
@ 2020-10-15 13:35 ` Eli Zaretskii
2020-10-15 14:05 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2020-10-15 13:35 UTC (permalink / raw)
To: Akira Kyle; +Cc: emacs-devel
> From: Akira Kyle <ak@akirakyle.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 14 Oct 2020 13:15:39 -0600
>
>
> > The calls to this function were removed from the GUI display code
> > when we deleted the "direct output for insert" redisplay
> > optimization.
>
> Thanks! Then I assume this was kept around in case someone in the
> future wanted to utilize that part of the redisplay_interface?
Maybe. Or maybe we simply didn't pay attention that there are no
callers of this functions anymore.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: gui_insert_glyphs in xdisp.c
2020-10-15 13:35 ` Eli Zaretskii
@ 2020-10-15 14:05 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2020-10-15 14:05 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Akira Kyle, emacs-devel
>> > The calls to this function were removed from the GUI display code
>> > when we deleted the "direct output for insert" redisplay
>> > optimization.
>> Thanks! Then I assume this was kept around in case someone in the
>> future wanted to utilize that part of the redisplay_interface?
> Maybe. Or maybe we simply didn't pay attention that there are no
> callers of this functions anymore.
As the guy who removed those optimizations, I must admit that I didn't
realize it made those functions dead code. So it definitely wasn't done
"in case someone in the future wanted to utilize that part of the
redisplay_interface" ;-)
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-15 14:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 0:43 gui_insert_glyphs in xdisp.c Akira Kyle
2020-10-14 14:01 ` Eli Zaretskii
2020-10-14 19:15 ` Akira Kyle
2020-10-15 13:35 ` Eli Zaretskii
2020-10-15 14:05 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).