Re: master b89ae23636: Implement crossing event generation between windows for xwidgets on X

Re: master b89ae23636: Implement crossing event generation between windows for xwidgets on X

[Stefan Monnier]

>  #ifdef HAVE_X_WINDOWS
> +enum xw_crossing_mode
> +  {
> +    XW_CROSSING_LEFT,
> +    XW_CROSSING_ENTERED,
> +    XW_CROSSING_NONE
> +  };

I think this deserves some comments explaining what is "crossing" here.
Maybe a URL to some docs?


        Stefan

Re: master b89ae23636: Implement crossing event generation between windows for xwidgets on X

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>  #ifdef HAVE_X_WINDOWS
>> +enum xw_crossing_mode
>> +  {
>> +    XW_CROSSING_LEFT,
>> +    XW_CROSSING_ENTERED,
>> +    XW_CROSSING_NONE
>> +  };

> I think this deserves some comments explaining what is "crossing" here.
> Maybe a URL to some docs?

XW_CROSSING_LEFT and XW_CROSSING_ENTERED mean the same as they do on X,
so those two should be obvious to anyone with reason to look at the
xwidgets code.

XW_CROSSING_NONE is sent on a MotionNotify or an XI_Motion event, where
no crossing took place, so I think that's self-explanatory as well.

But if you still insist, I have no objections to installing a comment
explaining things there.

Re: master b89ae23636: Implement crossing event generation between windows for xwidgets on X

[Stefan Monnier]

>> I think this deserves some comments explaining what is "crossing" here.
>> Maybe a URL to some docs?
> XW_CROSSING_LEFT and XW_CROSSING_ENTERED mean the same as they do on X,
> so those two should be obvious to anyone with reason to look at the
> xwidgets code.

OK.  I'm obviously not well versed in GUI code, so maybe I'm
a bad judge.  But I have looked (and touched) at some of Emacs's GUI
code (e.g. had a hack to split key presses events into `a` and `up-a`)
so I'm at least remotely familiar with X11 events yet I've never heard
of "crossings" and have hence no clue what your code is about.

> But if you still insist, I have no objections to installing a comment
> explaining things there.

I don't insist, I'll let you judge.  I'm just pointing out that your
code looked completely mysterious to me.


        Stefan