unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: vibhavp@gmail.com
Cc: Eli Zaretskii <eliz@gnu.org>,
	 rms@gnu.org,  akrl@sdf.org, luangruo@yahoo.com,
	 emacs-devel@gnu.org
Subject: Re: scratch/comp-static-data 5aa3db2f11: comp: Add support for compiling elisp constants into static data.
Date: Sun, 20 Nov 2022 13:47:55 -0500	[thread overview]
Message-ID: <jwvo7t131tu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <18b7286a9bd88d8c30822d195d9893f1267fd665.camel@gmail.com> (vibhavp@gmail.com's message of "Sun, 20 Nov 2022 22:07:12 +0530")

> The follow elisp snipper is an example of code that when compiled under
> this branch, crashes Emacs:
> ;; -*- lexical-binding: t; -*-
> (defun fault-function ()
>   (let ((a [1 2 3]))
>     (aset a 0 5)
>     a))

I'm not deluded enough to think it's currently impossible to crash Emacs
with a well-crafted piece of ELisp code, but we do aim for that, so this
would be a significant step backwards :-(

Can we change your patch so that it makes the section writable rather
than ".rodata"?

Otherwise, we'd have to adjust the PURE_P tests so as to turn those
crashes into mere errors (I guess we could also try and use some kind of
SEGV signal handler for that purpose, but IIUC it can be tricky to do it
reliably/portably).


        Stefan




  parent reply	other threads:[~2022-11-20 18:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166844679660.19180.3470364122428955894@vcs2.savannah.gnu.org>
     [not found] ` <20221114172637.78215C0E4C7@vcs2.savannah.gnu.org>
2022-11-15  0:30   ` scratch/comp-static-data 5aa3db2f11: comp: Add support for compiling elisp constants into static data Po Lu
2022-11-15  9:06     ` Andrea Corallo
2022-11-16 19:36       ` Vibhav Pant
2022-11-17 19:59         ` Andrea Corallo
2022-11-17  4:32       ` Richard Stallman
2022-11-17  8:46         ` Vibhav Pant
2022-11-18  5:07           ` Richard Stallman
2022-11-18  8:28             ` Eli Zaretskii
2022-11-20  1:15               ` Richard Stallman
2022-11-20  7:37                 ` Eli Zaretskii
2022-11-20 16:37                   ` vibhavp
2022-11-20 16:54                     ` Eli Zaretskii
2022-11-20 18:47                     ` Stefan Monnier [this message]
2022-11-21 15:59                       ` vibhavp
2022-11-21  0:37                     ` Po Lu
2022-11-16 19:26     ` Vibhav Pant
2022-11-17  4:51       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvo7t131tu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rms@gnu.org \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).