unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: vibhavp@gmail.com
Cc: akrl@sdf.org, luangruo@yahoo.com, emacs-devel@gnu.org
Subject: Re: scratch/comp-static-data 5aa3db2f11: comp: Add support for compiling elisp constants into static data.
Date: Fri, 18 Nov 2022 00:07:00 -0500	[thread overview]
Message-ID: <E1ovtae-0005d9-Mh@fencepost.gnu.org> (raw)
In-Reply-To: <9c27dd84e3298e2ed979415016f2db75d1cef882.camel@gmail.com> (message from Vibhav Pant on Thu, 17 Nov 2022 14:16:19 +0530)

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Perhaps "constant" is a misnomer here. If you are refering to defconst-
  > defined variables, that is not what the patch is about. I'm refering to
  > self-evaluating forms/objects referenced by elisp code, i.e. the ones
  > that the constant vector in a bytecode object contains. The elisp
  > reference manual states that mutating self-evaluating forms results in
  > undefined behaviour, so marking them as const should be safe IMO.

Your change "ought to be" harmless in principle, but in practice it
may be harmful.  There may be cases that are currently "incorrect" in
principle but in practice do no harm.  Your change might cause them to
get faults for trying to write read-only memory.  Why take that risk?

I'd rather avoid risk by not making this change.


-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





  reply	other threads:[~2022-11-18  5:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166844679660.19180.3470364122428955894@vcs2.savannah.gnu.org>
     [not found] ` <20221114172637.78215C0E4C7@vcs2.savannah.gnu.org>
2022-11-15  0:30   ` scratch/comp-static-data 5aa3db2f11: comp: Add support for compiling elisp constants into static data Po Lu
2022-11-15  9:06     ` Andrea Corallo
2022-11-16 19:36       ` Vibhav Pant
2022-11-17 19:59         ` Andrea Corallo
2022-11-17  4:32       ` Richard Stallman
2022-11-17  8:46         ` Vibhav Pant
2022-11-18  5:07           ` Richard Stallman [this message]
2022-11-18  8:28             ` Eli Zaretskii
2022-11-20  1:15               ` Richard Stallman
2022-11-20  7:37                 ` Eli Zaretskii
2022-11-20 16:37                   ` vibhavp
2022-11-20 16:54                     ` Eli Zaretskii
2022-11-20 18:47                     ` Stefan Monnier
2022-11-21 15:59                       ` vibhavp
2022-11-21  0:37                     ` Po Lu
2022-11-16 19:26     ` Vibhav Pant
2022-11-17  4:51       ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1ovtae-0005d9-Mh@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).