* Re: master 7551aff 4/4: Bind switch-to-buffer-obey-display-actions to t
[not found] ` <20200726235727.D751320A1C@vcs0.savannah.gnu.org>
@ 2020-07-27 2:07 ` Stefan Monnier
2020-07-27 3:27 ` Sean Whitton
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2020-07-27 2:07 UTC (permalink / raw)
To: emacs-devel; +Cc: Dmitry Gutov
> Bind switch-to-buffer-obey-display-actions to t
This sounds wrong. Why not change the rest of the code to use
`pop-to-buffer-same-window` instead?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 7551aff 4/4: Bind switch-to-buffer-obey-display-actions to t
2020-07-27 2:07 ` master 7551aff 4/4: Bind switch-to-buffer-obey-display-actions to t Stefan Monnier
@ 2020-07-27 3:27 ` Sean Whitton
2020-07-27 14:10 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Sean Whitton @ 2020-07-27 3:27 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel; +Cc: Dmitry Gutov
Hello Stefan,
On Sun 26 Jul 2020 at 10:07PM -04, Stefan Monnier wrote:
>> Bind switch-to-buffer-obey-display-actions to t
>
> This sounds wrong. Why not change the rest of the code to use
> `pop-to-buffer-same-window` instead?
AIUI Dmitry made this change purely so that project-switch-to-buffer
would work with project-other-*-command. So are you suggesting that
project-switch-to-buffer use pop-to-buffer-same-window?
I think that would not be ideal, because for users with
switch-to-buffer-obey-display-actions set to nil globally, it is good
that switch-to-buffer unconditionally uses the selected window, and it
seems that project-switch-to-buffer should be consistent with
switch-to-buffer.
--
Sean Whitton
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 7551aff 4/4: Bind switch-to-buffer-obey-display-actions to t
2020-07-27 3:27 ` Sean Whitton
@ 2020-07-27 14:10 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2020-07-27 14:10 UTC (permalink / raw)
To: Sean Whitton; +Cc: Dmitry Gutov, emacs-devel
>>> Bind switch-to-buffer-obey-display-actions to t
>> This sounds wrong. Why not change the rest of the code to use
>> `pop-to-buffer-same-window` instead?
> AIUI Dmitry made this change purely so that project-switch-to-buffer
> would work with project-other-*-command. So are you suggesting that
> project-switch-to-buffer use pop-to-buffer-same-window?
Yes.
> I think that would not be ideal, because for users with
> switch-to-buffer-obey-display-actions set to nil globally, it is good
> that switch-to-buffer unconditionally uses the selected window, and it
`pop-to-buffer-same-window` uses the selected window "unconditionally"
in 99.9763% (seat of pants estimate) of the cases. And the here patch
shows that we don't want this code to use the selected window
unconditionally in 100% of the cases, so `pop-to-buffer-same-window`
seems exactly like what we need.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-27 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200726235725.458.96146@vcs0.savannah.gnu.org>
[not found] ` <20200726235727.D751320A1C@vcs0.savannah.gnu.org>
2020-07-27 2:07 ` master 7551aff 4/4: Bind switch-to-buffer-obey-display-actions to t Stefan Monnier
2020-07-27 3:27 ` Sean Whitton
2020-07-27 14:10 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).