From: Stefan Monnier <monnier@iro.umontreal.ca>
To: haj@posteo.de (Harald Jörg)
Cc: Emacs Developer List <emacs-devel@gnu.org>
Subject: Re: newline-and-indent vs. electric-indent-mode
Date: Fri, 22 Jan 2021 09:49:14 -0500 [thread overview]
Message-ID: <jwvlfcluj5u.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wnw5yt58.fsf@hajtower> ("Harald Jörg"'s message of "Fri, 22 Jan 2021 14:53:55 +0100")
> Many (almost all?) modes bind RET to newline-and-indent,
Any mode which does that should be fixed. Whether RET indents or not is
a user preference, not something that should depend on the kind of
language you're editing.
> So, whenever a newline is entered,
By that I assume you simply mean whenever `newline-and-indent` is executed?
> there are three calls to the mode-specific indenting function:
>
> - one call for the current line, caused by electric-indent-mode. This
> makes some sense because the line's content might suggest a different
> indentation than what could be guessed when the line started out as a
> new empty line. It is annoying, however, when the mode gets the
> indentation wrong (which occasionally happens). It is also
> superfluous if the character which causes a change in indentation
> (for example "}") is either itself in electric-indent-chars (as in
> perl-mode) or handled by the mode's keymap (as in cperl-mode), both
> resulting in a call to the indenting function.
>
> - two calls for the following, empty line. One is caused by '(?\n)
> being in electric-indent-chars, the other by the current command
> being newline-AND-INDENT. This doesn't make any sense.
It sounds like a bug indeed. I think both having two calls (one for
each line) or having one call (for the new line) could arguably be
correct, but three calls is indeed an error.
> Or should the modes refrain from mapping RET?
Very much so, yes (unless there's a good language-related reason why RET
should behave differently for that specific language). But that doesn't
change the fact that `newline-and-indent` should work right, including
not calling the indent function redundantly.
Stefan
next prev parent reply other threads:[~2021-01-22 14:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 13:53 newline-and-indent vs. electric-indent-mode Harald Jörg
2021-01-22 14:49 ` Stefan Monnier [this message]
2021-01-22 15:02 ` Dmitry Gutov
2021-01-22 15:09 ` Stefan Monnier
2021-01-22 22:43 ` Dmitry Gutov
2021-01-22 22:56 ` Stefan Monnier
2021-01-22 23:00 ` Dmitry Gutov
2021-01-22 23:16 ` Stefan Monnier
2021-01-23 0:45 ` Dmitry Gutov
2021-01-23 3:16 ` Stefan Monnier
2021-01-24 2:54 ` Dmitry Gutov
2021-01-24 5:29 ` Stefan Monnier
2021-01-24 21:45 ` Dmitry Gutov
2021-01-25 1:56 ` Madhu
2021-01-25 2:29 ` Dmitry Gutov
2021-01-25 10:45 ` Madhu
2021-01-25 11:59 ` Dmitry Gutov
2021-01-25 14:36 ` Stefan Monnier
2021-01-25 14:42 ` Dmitry Gutov
2021-01-25 15:15 ` Stefan Monnier
2021-01-25 20:10 ` Rudolf Schlatte
2021-01-26 2:04 ` Dmitry Gutov
2021-01-26 2:43 ` Stefan Monnier
2021-01-26 15:58 ` martin rudalics
2021-01-25 3:33 ` Eli Zaretskii
2021-01-22 19:33 ` Harald Jörg
2021-01-22 22:05 ` Stefan Monnier
2021-01-23 2:19 ` Harald Jörg
2021-01-23 3:29 ` Stefan Monnier
2021-01-23 16:27 ` Harald Jörg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlfcluj5u.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=haj@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).