unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Harald Jörg" <haj@posteo.de>,
	"Emacs Developer List" <emacs-devel@gnu.org>
Subject: Re: newline-and-indent vs. electric-indent-mode
Date: Sat, 23 Jan 2021 02:45:01 +0200	[thread overview]
Message-ID: <66b7932d-4cee-9628-fae0-168ee6ebc041@yandex.ru> (raw)
In-Reply-To: <jwvft2ssgzu.fsf-monnier+emacs@gnu.org>

On 23.01.2021 01:16, Stefan Monnier wrote:
>>>> That would disable the effects of electric-indent-functions, and in
>>>> particular, of ruby--electric-indent-p.
>>> I don't see why.  AFAIK it should only inhibit the "reindent original
>>> line when inserting \n".  It should affect indentation of the line after
>>> the inserted \n nor should it affect indentation when inserting
>>> other chars.
>> It also affect "reindent original line when inserting something other than
>> \n", which is what ruby--electric-indent-p is all about (e.g. I type 'd'
>> finishing the token 'end', and the line is reindented).
> 
> Hmm... indeed I now see that the code also inhibits reindentation in
> that case.  Weird!
> Could you open a bug report for this?

I'm not sure how it is a bug. It's "reindentation" in both cases, right?

And electric-indent-inhibit's docstring refers to reindentation.

>> It's just that in my mental model \n doesn't belong to the current line,
>> only to the next one. So it shouldn't reindent the original line.
> 
> It's often useful for me, as in typing
> 
>      foo RET else RET blabla
> 
> where the else benefits from being reindented upon the second RET.

I see. Well, ruby--electric-indent-p covers this scenario already.

Perhaps your approach is simpler, but always reindenting the original 
line gets annoying if the indentation function sometimes produces 
suboptimal results. Or, you know, just results that disagree with the 
style guide used in a project. Then I have to go back and change the 
indentation manually again, or undo the change and go with C-o C-n TAB.



  reply	other threads:[~2021-01-23  0:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 13:53 newline-and-indent vs. electric-indent-mode Harald Jörg
2021-01-22 14:49 ` Stefan Monnier
2021-01-22 15:02   ` Dmitry Gutov
2021-01-22 15:09     ` Stefan Monnier
2021-01-22 22:43       ` Dmitry Gutov
2021-01-22 22:56         ` Stefan Monnier
2021-01-22 23:00           ` Dmitry Gutov
2021-01-22 23:16             ` Stefan Monnier
2021-01-23  0:45               ` Dmitry Gutov [this message]
2021-01-23  3:16                 ` Stefan Monnier
2021-01-24  2:54                   ` Dmitry Gutov
2021-01-24  5:29                     ` Stefan Monnier
2021-01-24 21:45                       ` Dmitry Gutov
2021-01-25  1:56                   ` Madhu
2021-01-25  2:29                     ` Dmitry Gutov
2021-01-25 10:45                       ` Madhu
2021-01-25 11:59                         ` Dmitry Gutov
2021-01-25 14:36                         ` Stefan Monnier
2021-01-25 14:42                           ` Dmitry Gutov
2021-01-25 15:15                             ` Stefan Monnier
2021-01-25 20:10                               ` Rudolf Schlatte
2021-01-26  2:04                               ` Dmitry Gutov
2021-01-26  2:43                                 ` Stefan Monnier
2021-01-26 15:58                               ` martin rudalics
2021-01-25  3:33                     ` Eli Zaretskii
2021-01-22 19:33   ` Harald Jörg
2021-01-22 22:05     ` Stefan Monnier
2021-01-23  2:19       ` Harald Jörg
2021-01-23  3:29         ` Stefan Monnier
2021-01-23 16:27           ` Harald Jörg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66b7932d-4cee-9628-fae0-168ee6ebc041@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=haj@posteo.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).