unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111589: * insdel.c (prepare_to_modify_buffer): Force redisplay if
       [not found] <E1Ty252-0001kh-No@vcs.savannah.gnu.org>
@ 2013-01-23 20:43 ` Stefan Monnier
  2013-01-24  3:47   ` Dmitry Antipov
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2013-01-23 20:43 UTC (permalink / raw)
  To: Dmitry Antipov; +Cc: emacs-devel

>    /* If we're modifying the buffer other than shown in a selected window,
> -     let redisplay consider other windows if this buffer is visible.  */
> +     let redisplay consider other windows if this buffer is visible or
> +     hidden (although hidden buffers have zero window counts, their state
> +     may affect the display too, e.g. via mode lines of other buffers).  */
>    if (XBUFFER (XWINDOW (selected_window)->buffer) != current_buffer
> -      && buffer_window_count (current_buffer))
> +      && (buffer_window_count (current_buffer)
> +	  || BUFFER_HIDDEN_P (current_buffer)))
>      ++windows_or_buffers_changed;

The redisplay code should not treat "hidden" buffers specially.
Better revert this change and install the doc-view patch
I suggested instead.


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111589: * insdel.c (prepare_to_modify_buffer): Force redisplay if
  2013-01-23 20:43 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111589: * insdel.c (prepare_to_modify_buffer): Force redisplay if Stefan Monnier
@ 2013-01-24  3:47   ` Dmitry Antipov
  2013-01-24 13:36     ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Antipov @ 2013-01-24  3:47 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

On 01/24/2013 12:43 AM, Stefan Monnier wrote:

> The redisplay code should not treat "hidden" buffers specially.
> Better revert this change and install the doc-view patch
> I suggested instead.

OK. BTW, is there any Lisp code which may be affected with the
similar issue?

Dmitry




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111589: * insdel.c (prepare_to_modify_buffer): Force redisplay if
  2013-01-24  3:47   ` Dmitry Antipov
@ 2013-01-24 13:36     ` Stefan Monnier
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2013-01-24 13:36 UTC (permalink / raw)
  To: Dmitry Antipov; +Cc: emacs-devel

>> The redisplay code should not treat "hidden" buffers specially.
>> Better revert this change and install the doc-view patch
>> I suggested instead.
> OK.  BTW, is there any Lisp code which may be affected with the
> similar issue?

Maybe.  We'll only know when people notice it, tho.


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-24 13:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Ty252-0001kh-No@vcs.savannah.gnu.org>
2013-01-23 20:43 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111589: * insdel.c (prepare_to_modify_buffer): Force redisplay if Stefan Monnier
2013-01-24  3:47   ` Dmitry Antipov
2013-01-24 13:36     ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).