From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 306a6f8: * lisp/gnus/gnus-art.el (gnus-article-prepare): Make sure the article
Date: Fri, 13 Apr 2018 13:35:21 -0400 [thread overview]
Message-ID: <jwvk1tbc8nu.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 5AD04EC4.3000600@gmx.at
>>> + ;; Make sure the article begins with the top of the header.
>>> + (save-selected-window
>>> + (select-window (get-buffer-window gnus-article-buffer))
>>> + (goto-char (point-min)))
>> Any reason this doesn't use `with-selected-window`?
> There's no need to _select_ the window. What Lars wants is probably
Duh! I focused on the `save-selected-window` (which is rarely "quite
right" in my experience) and completely missed the rest. Thanks!
Stefan
prev parent reply other threads:[~2018-04-13 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180412231938.8195.10463@vcs0.savannah.gnu.org>
[not found] ` <20180412231940.042652052F@vcs0.savannah.gnu.org>
2018-04-13 2:27 ` [Emacs-diffs] master 306a6f8: * lisp/gnus/gnus-art.el (gnus-article-prepare): Make sure the article Stefan Monnier
2018-04-13 6:31 ` martin rudalics
2018-04-13 7:42 ` Katsumi Yamaoka
2018-04-13 17:35 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk1tbc8nu.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).