From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 306a6f8: * lisp/gnus/gnus-art.el (gnus-article-prepare): Make sure the article Date: Fri, 13 Apr 2018 13:35:21 -0400 Message-ID: References: <20180412231938.8195.10463@vcs0.savannah.gnu.org> <20180412231940.042652052F@vcs0.savannah.gnu.org> <5AD04EC4.3000600@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523640813 32697 195.159.176.226 (13 Apr 2018 17:33:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Apr 2018 17:33:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 13 19:33:29 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f72Zl-0008OP-7C for ged-emacs-devel@m.gmane.org; Fri, 13 Apr 2018 19:33:29 +0200 Original-Received: from localhost ([::1]:41015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f72br-0005bC-VI for ged-emacs-devel@m.gmane.org; Fri, 13 Apr 2018 13:35:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f72bl-0005aY-C0 for emacs-devel@gnu.org; Fri, 13 Apr 2018 13:35:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f72bg-0004VY-F6 for emacs-devel@gnu.org; Fri, 13 Apr 2018 13:35:33 -0400 Original-Received: from [195.159.176.226] (port=34322 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f72bg-0004Uz-7f for emacs-devel@gnu.org; Fri, 13 Apr 2018 13:35:28 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1f72ZX-00086j-KM for emacs-devel@gnu.org; Fri, 13 Apr 2018 19:33:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 12 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:WMg2+Y1eUox6UNFnki3siFYoXnU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224552 Archived-At: >>> + ;; Make sure the article begins with the top of the header. >>> + (save-selected-window >>> + (select-window (get-buffer-window gnus-article-buffer)) >>> + (goto-char (point-min))) >> Any reason this doesn't use `with-selected-window`? > There's no need to _select_ the window. What Lars wants is probably Duh! I focused on the `save-selected-window` (which is rarely "quite right" in my experience) and completely missed the rest. Thanks! Stefan