unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Where is sr-speedbar.el upstream repo?
@ 2022-07-04 23:21 chen.mingzheng
  2022-07-05  0:38 ` Stefan Kangas
  0 siblings, 1 reply; 13+ messages in thread
From: chen.mingzheng @ 2022-07-04 23:21 UTC (permalink / raw)
  To: emacs-devel

Hello hackers,

I'm add a new feature to sr-speedbar, but I can't find its upstream 
repo, Does anyone know where it is? Or should I just send the patch to 
this maillist?

Btw, the content of patch is:

diff --git a/sr-speedbar.el b/sr-speedbar.el
index a4ee4bed0..cf86914bf 100644
--- a/sr-speedbar.el
+++ b/sr-speedbar.el
@@ -78,6 +78,12 @@
  ;;      M-x customize-group RET sr-speedbar RET

  ;;; Change log:
+;; * 04 July 2022:
+;;   * Doerthous <doerthous@gmail.com>
+;;     * Add support that allows speedbar window split from 
`selected-window'
+;;       or `frame-root-window'.
+;;     * define `sr-speedbar-use-frame-root-window'.
+;;
  ;; * 22 Sep 2021:
  ;;   * Vasilij Schneidermann <mail@vasilij.de>
  ;;     * Fix cl deprecation warning
@@ -325,6 +331,16 @@ Default is nil."
    :type 'boolean
    :group 'sr-speedbar)

+(defcustom sr-speedbar-use-frame-root-window nil
+  "Open speedbar based on selected window or frame root window.
+If nil, the speedbar window will split from `selected-window'.
+Otherwise `frame-root-window'.
+Default is nil."
+  :type 'boolean
+  :set (lambda (symbol value)
+         (set symbol value))
+  :group 'sr-speedbar)
+
  (if (not (fboundp 'ad-advised-definition-p))
      (defun ad-advised-definition-p (definition)
        "Return non-nil if DEFINITION was generated from advice 
information."
@@ -514,7 +530,9 @@ Otherwise return nil."
  (defun sr-speedbar-get-window ()
    "Get `sr-speedbar' window."
    (setq sr-speedbar-window
-        (split-window (selected-window)
+        (split-window (if sr-speedbar-use-frame-root-window
+                          (frame-root-window)
+                        (selected-window))
                        (- sr-speedbar-width)
                        (if sr-speedbar-right-side 'right 'left))))

Thanks in advance, and apologies if this is not the right place to ask.

Doerthous.



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-04 23:21 Where is sr-speedbar.el upstream repo? chen.mingzheng
@ 2022-07-05  0:38 ` Stefan Kangas
  2022-07-05  0:51   ` chen.mingzheng
  0 siblings, 1 reply; 13+ messages in thread
From: Stefan Kangas @ 2022-07-05  0:38 UTC (permalink / raw)
  To: chen.mingzheng; +Cc: Emacs developers

chen.mingzheng <chen.mingzheng@outlook.com> writes:

> I'm add a new feature to sr-speedbar, but I can't find its upstream
> repo, Does anyone know where it is? Or should I just send the patch to
> this maillist?

It seems like this package is in the Emacs orphanage, which means that
it is lacking a maintainer.  According to emacsmirror.net:

"If other mirrored packages still depend on a package whose upstream
has disappeared or no longer maintains the package, then it is copied
to the Emacsorphanage. The Emacsmirror then mirrors that repository
from the orphanage. The orphanage repository serves as a temporary
home until someone volunteers to take over as maintainer. While a
package is in the orphanage, the maintainer of the Emacsmirror makes
an effort to merge pull requests from users."

So I think you should just send a pull request here:
https://github.com/emacsorphanage/sr-speedbar

Happy to help.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05  0:38 ` Stefan Kangas
@ 2022-07-05  0:51   ` chen.mingzheng
  2022-07-05  1:26     ` Stefan Kangas
  0 siblings, 1 reply; 13+ messages in thread
From: chen.mingzheng @ 2022-07-05  0:51 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

Hi Stefan,

Thanks for reply. I noticed the repo you post, but it has not updated 
for a long time. The latest changelog in 
https://github.com/emacsorphanage/sr-speedbar was 20161025, but the 
version in my .emacs.d/ is 20210922. So I guess there may be the latest 
version somewhere, however google show me little infomation about that.

在 2022/7/5 8:38, Stefan Kangas 写道:
> chen.mingzheng <chen.mingzheng@outlook.com> writes:
> 
>> I'm add a new feature to sr-speedbar, but I can't find its upstream
>> repo, Does anyone know where it is? Or should I just send the patch to
>> this maillist?
> 
> It seems like this package is in the Emacs orphanage, which means that
> it is lacking a maintainer.  According to emacsmirror.net:
> 
> "If other mirrored packages still depend on a package whose upstream
> has disappeared or no longer maintains the package, then it is copied
> to the Emacsorphanage. The Emacsmirror then mirrors that repository
> from the orphanage. The orphanage repository serves as a temporary
> home until someone volunteers to take over as maintainer. While a
> package is in the orphanage, the maintainer of the Emacsmirror makes
> an effort to merge pull requests from users."
> 
> So I think you should just send a pull request here:
> https://github.com/emacsorphanage/sr-speedbar
> 
> Happy to help.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05  0:51   ` chen.mingzheng
@ 2022-07-05  1:26     ` Stefan Kangas
  2022-07-05  1:59       ` chen.mingzheng
  2022-07-05  6:56       ` Sebastian Rose
  0 siblings, 2 replies; 13+ messages in thread
From: Stefan Kangas @ 2022-07-05  1:26 UTC (permalink / raw)
  To: chen.mingzheng; +Cc: Emacs developers, Sebastian Rose

chen.mingzheng <chen.mingzheng@outlook.com> writes:

> Thanks for reply. I noticed the repo you post, but it has not updated
> for a long time. The latest changelog in
> https://github.com/emacsorphanage/sr-speedbar was 20161025, but the
> version in my .emacs.d/ is 20210922. So I guess there may be the latest
> version somewhere, however google show me little infomation about that.

Perhaps the canonical version is the one on Emacs mirror, here:
https://www.emacswiki.org/emacs/sr-speedbar.el

I've Cc:ed the maintainer in case he has anything to add.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05  1:26     ` Stefan Kangas
@ 2022-07-05  1:59       ` chen.mingzheng
  2022-07-05  6:56       ` Sebastian Rose
  1 sibling, 0 replies; 13+ messages in thread
From: chen.mingzheng @ 2022-07-05  1:59 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel, sebastian_rose

I actually sent a PR to emacswiki, but its maintainer said it's not the 
right place to submit a patch there. The maintainer of emacswiki doesn't 
know where the repo of sr-speedbar.el either, and suggests that send a 
patch to emacs-bug-report maillist. So I now get here.

For convenience, here is the link for the PR: 
https://github.com/emacsmirror/emacswiki.org/pull/11

Thanks

在 2022/7/5 9:26, Stefan Kangas 写道:
> chen.mingzheng <chen.mingzheng@outlook.com> writes:
> 
>> Thanks for reply. I noticed the repo you post, but it has not updated
>> for a long time. The latest changelog in
>> https://github.com/emacsorphanage/sr-speedbar was 20161025, but the
>> version in my .emacs.d/ is 20210922. So I guess there may be the latest
>> version somewhere, however google show me little infomation about that.
> 
> Perhaps the canonical version is the one on Emacs mirror, here:
> https://www.emacswiki.org/emacs/sr-speedbar.el
> 
> I've Cc:ed the maintainer in case he has anything to add.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05  1:26     ` Stefan Kangas
  2022-07-05  1:59       ` chen.mingzheng
@ 2022-07-05  6:56       ` Sebastian Rose
  2022-07-05  9:34         ` chen.mingzheng
  1 sibling, 1 reply; 13+ messages in thread
From: Sebastian Rose @ 2022-07-05  6:56 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: chen.mingzheng, Emacs developers

Stefan Kangas <stefan@marxist.se> writes:
> chen.mingzheng <chen.mingzheng@outlook.com> writes:
>
>> Thanks for reply. I noticed the repo you post, but it has not updated
>> for a long time. The latest changelog in
>> https://github.com/emacsorphanage/sr-speedbar was 20161025, but the
>> version in my .emacs.d/ is 20210922. So I guess there may be the latest
>> version somewhere, however google show me little infomation about that.
>
> Perhaps the canonical version is the one on Emacs mirror, here:
> https://www.emacswiki.org/emacs/sr-speedbar.el
>
> I've Cc:ed the maintainer in case he has anything to add.

Hello Chen,

there simply is no, and never has been any, repo for this little
project.  I wouldn't mind if someone created one though.  I just don't
want to maintain software I don't use anymore.

 - Sebastian



-- 
As I was walking down Stanton Street early one Sunday morning, I saw a
chicken a few yards ahead of me. I was walking faster than the
chicken, so I gradually caught up.  By the time we approached
Eighteenth Avenue, I was close behind.  The chicken turned south on
Eighteenth.  At the fourth house along, it turned in at the walk,
hopped up the front steps, and rapped sharply on the metal storm door
with its beak. After a moment, the door opened and the chicken went
in.

                      (Linda Elegant in "True Tales of American Life")
⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽
Sebastian  Rose                                    Software Entwickler
Waldenburger Straße 2
31162 Bad Salzdetfurth

Telefon: 05063 78 14 3 17
Mobil :  0157  75 460 462               E-Mail:  sebastian_rose@gmx.de
⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺⎺

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05  6:56       ` Sebastian Rose
@ 2022-07-05  9:34         ` chen.mingzheng
  2022-07-05 12:03           ` Stefan Monnier
  0 siblings, 1 reply; 13+ messages in thread
From: chen.mingzheng @ 2022-07-05  9:34 UTC (permalink / raw)
  To: Sebastian Rose; +Cc: emacs-devel

Hello Sebastian,

Tranks for reply. I will try to port the recent changes of 
sr-speedbar.el made in [1], then send a PR to [2], and expect [2] become 
the upstream repo of sr-speedbar.el for those who want to contribute 
code to it.

[1]: https://www.emacswiki.org/emacs/sr-speedbar.el
[2]: https://github.com/emacsorphanage/sr-speedbar

Thanks again

在 2022/7/5 14:56, Sebastian Rose 写道:
> Stefan Kangas <stefan@marxist.se> writes:
>> chen.mingzheng <chen.mingzheng@outlook.com> writes:
>>
>>> Thanks for reply. I noticed the repo you post, but it has not updated
>>> for a long time. The latest changelog in
>>> https://github.com/emacsorphanage/sr-speedbar was 20161025, but the
>>> version in my .emacs.d/ is 20210922. So I guess there may be the latest
>>> version somewhere, however google show me little infomation about that.
>>
>> Perhaps the canonical version is the one on Emacs mirror, here:
>> https://www.emacswiki.org/emacs/sr-speedbar.el
>>
>> I've Cc:ed the maintainer in case he has anything to add.
> 
> Hello Chen,
> 
> there simply is no, and never has been any, repo for this little
> project.  I wouldn't mind if someone created one though.  I just don't
> want to maintain software I don't use anymore.
> 
>   - Sebastian
> 
> 
> 



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05  9:34         ` chen.mingzheng
@ 2022-07-05 12:03           ` Stefan Monnier
       [not found]             ` <TYCPR01MB5743F6F10A0573375954655681819@TYCPR01MB5743.jpnprd01.prod.outlook.com>
  0 siblings, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2022-07-05 12:03 UTC (permalink / raw)
  To: chen.mingzheng; +Cc: Sebastian Rose, emacs-devel

chen.mingzheng [2022-07-05 17:34:45] wrote:
> made in [1], then send a PR to [2], and expect [2] become the upstream repo
> of sr-speedbar.el for those who want to contribute code to it.

To increase the probability of your expectation being true, I'd
recommend putting a "URL:" header that points there.
And if you can arrange for the emacswiki.org copy to be either removed
(ideally) or updated to point to that same upstream, even better,


        Stefan




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
       [not found]               ` <jwv7d4rk5by.fsf-monnier+emacs@gnu.org>
@ 2022-07-05 15:49                 ` chen.mingzheng
  2022-07-05 15:55                   ` Stefan Monnier
  0 siblings, 1 reply; 13+ messages in thread
From: chen.mingzheng @ 2022-07-05 15:49 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

在 2022/7/5 22:22, Stefan Monnier 写道:
 > It's the result of nobody having the guts to consider
 > themselves maintainer

I'm curious why is that happens. What are the responsibilities for a 
maintainer and what gonna happens if someone want to be a maintainer for 
it. managing PRs, fixing bug for some PR and so on?

在 2022/7/5 22:22, Stefan Monnier 写道:
>> I found that there were some closed PR (which were not merged) in
>> https://github.com/emacsorphanage/sr-speedbar. A member of the repo said the
>> repo is only a mirror, and reject the patch, see [1]. So, I'm
>> confused again.
>>
>> Then I edit the emacswiki page at [2], and it seems ok to me. So I guess
>> sr-speedbar.sl is maintaining directly in [2] by other developers. Is it
>> a little bit weird?
> 
> Yes.  It's the result of nobody having the guts to consider
> themselves maintainer.  It's not hard.  Do it.
> 
> 
>          Stefan
> 



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05 15:49                 ` chen.mingzheng
@ 2022-07-05 15:55                   ` Stefan Monnier
  2022-07-05 16:56                     ` Lynn Winebarger
  0 siblings, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2022-07-05 15:55 UTC (permalink / raw)
  To: chen.mingzheng; +Cc: emacs-devel

> I'm curious why is that happens. What are the responsibilities for
> a maintainer

Nobody can sue the maintainer for not doing its job, so in terms of real
responsibilities there aren't any, but in terms of what's expected, it's
mostly to be responsive and to care about the package.

> and what gonna happens if someone want to be a maintainer for it.

The world will rejoice and there will be much celebration.

> managing PRs, fixing bug for some PR and so on?

That's right.


        Stefan




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05 15:55                   ` Stefan Monnier
@ 2022-07-05 16:56                     ` Lynn Winebarger
  2022-07-05 18:39                       ` Akib Azmain Turja
  2022-07-05 18:40                       ` Stefan Monnier
  0 siblings, 2 replies; 13+ messages in thread
From: Lynn Winebarger @ 2022-07-05 16:56 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: chen.mingzheng, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Tue, Jul 5, 2022, 11:57 AM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> > I'm curious why is that happens. What are the responsibilities for
> > a maintainer
>
> Nobody can sue the maintainer for not doing its job, so in terms of real
> responsibilities there aren't any, but in terms of what's expected, it's
> mostly to be responsive and to care about the package.
>

I'm curious about why the same-frame functionality hasn't been absorbed
into the speedbar package itself.  The appearance of a "project explorer"
that doesn't "dock" in the project frame has always been a jarring
disconnect from the way other IDEs implement this idiom for me.

[-- Attachment #2: Type: text/html, Size: 1231 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05 16:56                     ` Lynn Winebarger
@ 2022-07-05 18:39                       ` Akib Azmain Turja
  2022-07-05 18:40                       ` Stefan Monnier
  1 sibling, 0 replies; 13+ messages in thread
From: Akib Azmain Turja @ 2022-07-05 18:39 UTC (permalink / raw)
  To: Lynn Winebarger, Stefan Monnier; +Cc: chen.mingzheng, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

Lynn Winebarger <owinebar@gmail.com> writes:

> On Tue, Jul 5, 2022, 11:57 AM Stefan Monnier <monnier@iro.umontreal.ca>
> wrote:
>
>> > I'm curious why is that happens. What are the responsibilities for
>> > a maintainer
>>
>> Nobody can sue the maintainer for not doing its job, so in terms of real
>> responsibilities there aren't any, but in terms of what's expected, it's
>> mostly to be responsive and to care about the package.
>>
>
> I'm curious about why the same-frame functionality hasn't been absorbed
> into the speedbar package itself.  The appearance of a "project explorer"
> that doesn't "dock" in the project frame has always been a jarring
> disconnect from the way other IDEs implement this idiom for me.

Exactly what I was going to ask.  And it also seems that speedbar has
poor support for keyboard.  I wish I could use Dired on the symbols of a
C file.

-- 
Akib Azmain Turja

This message is signed by me with my GnuPG key.  It's fingerprint is:

    7001 8CE5 819F 17A3 BBA6  66AF E74F 0EFA 922A E7F5

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Where is sr-speedbar.el upstream repo?
  2022-07-05 16:56                     ` Lynn Winebarger
  2022-07-05 18:39                       ` Akib Azmain Turja
@ 2022-07-05 18:40                       ` Stefan Monnier
  1 sibling, 0 replies; 13+ messages in thread
From: Stefan Monnier @ 2022-07-05 18:40 UTC (permalink / raw)
  To: Lynn Winebarger; +Cc: chen.mingzheng, emacs-devel

> I'm curious about why the same-frame functionality hasn't been absorbed
> into the speedbar package itself.  The appearance of a "project explorer"

AFAIK it's because nobody has submitted a patch to do that.


        Stefan




^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-07-05 18:40 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 23:21 Where is sr-speedbar.el upstream repo? chen.mingzheng
2022-07-05  0:38 ` Stefan Kangas
2022-07-05  0:51   ` chen.mingzheng
2022-07-05  1:26     ` Stefan Kangas
2022-07-05  1:59       ` chen.mingzheng
2022-07-05  6:56       ` Sebastian Rose
2022-07-05  9:34         ` chen.mingzheng
2022-07-05 12:03           ` Stefan Monnier
     [not found]             ` <TYCPR01MB5743F6F10A0573375954655681819@TYCPR01MB5743.jpnprd01.prod.outlook.com>
     [not found]               ` <jwv7d4rk5by.fsf-monnier+emacs@gnu.org>
2022-07-05 15:49                 ` chen.mingzheng
2022-07-05 15:55                   ` Stefan Monnier
2022-07-05 16:56                     ` Lynn Winebarger
2022-07-05 18:39                       ` Akib Azmain Turja
2022-07-05 18:40                       ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).