keymap.el and its checks

keymap.el and its checks

[T.V Raman]

I saw this change from Stefan:
570a11052b * keymap.el: Ease up support for non-`kbd` formats.

and thought this would let me write 
(push repeat-exit-key unread-command-events)

but it still produces 
 KEY must be an integer, cons, symbol, or string
after update/recompile/restart?

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

Re: keymap.el and its checks

[Stefan Monnier]

> I saw this change from Stefan:
> 570a11052b * keymap.el: Ease up support for non-`kbd` formats.
>
> and thought this would let me write 
> (push repeat-exit-key unread-command-events)

No relation.
As for your problem: `unread-command-events` is defined tpo hold a list
of events.  `repeat-exit-key` is supposed to contain a key-sequence
(more or less an array of keys).  Keys and events are somewhat similar
so you can use keys as events.  But a key *sequence* is definitely not
an events.

You can use `listify-key-sequence`to turn the key sequence into a
list of keys, and then use `append`.


        Stefan

Re: keymap.el and its checks

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 114 bytes --]

Thanks!

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: keymap.el and its checks

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 319 bytes --]

The append  of listify-key-sequence works without any lisp errors, but
sadly it appears to not exit the repeat whereas pushing a raw 7 (rather
than a '(7) ) appears to work with respect to disabling the repeat.

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: keymap.el and its checks

[Stefan Monnier]

T.V Raman [2022-10-02 18:15:50] wrote:
> The append  of listify-key-sequence works without any lisp errors, but
> sadly it appears to not exit the repeat whereas pushing a raw 7 (rather
> than a '(7) ) appears to work with respect to disabling the repeat.

I think you still haven't understood that `unread-command-events`
contains a list of events.  Not a list of list of keys.
You have to use `append` (together with `setq`, presumably) *instead of*
`push`.


        Stefan

Re: keymap.el and its checks

[Juri Linkov]

> I saw this change from Stefan:
> 570a11052b * keymap.el: Ease up support for non-`kbd` formats.
>
> and thought this would let me write
> (push repeat-exit-key unread-command-events)

BTW, repeat-exit-key could support `kbd` format as well after changing
its customization type to:

  :type '(choice (const :tag "No special key to exit repeating sequence" nil)
                 (string :tag "Kbd string that exits repeating sequence")
                 (key-sequence :tag "Key that exits repeating sequence"))

This assumes that `key-sequence` can't be a string.

After that you could use (key-parse repeat-exit-key) to append it
to unread-command-events.

Re: keymap.el and its checks

[Stefan Monnier]

Juri Linkov [2022-10-03 09:58:56] wrote:

>> I saw this change from Stefan:
>> 570a11052b * keymap.el: Ease up support for non-`kbd` formats.
>>
>> and thought this would let me write
>> (push repeat-exit-key unread-command-events)
>
> BTW, repeat-exit-key could support `kbd` format as well after changing
> its customization type to:
>
>   :type '(choice (const :tag "No special key to exit repeating sequence" nil)
>                  (string :tag "Kbd string that exits repeating sequence")
>                  (key-sequence :tag "Key that exits repeating sequence"))
>
> This assumes that `key-sequence` can't be a string.

`key-sequence` can definitely be a string.

> After that you could use (key-parse repeat-exit-key) to append it
> to unread-command-events.

`key-parse` returns a ... key-sequence, so it's of no help to Raman's
"problem".


        Stefan

Re: keymap.el and its checks

[Juri Linkov]

>> BTW, repeat-exit-key could support `kbd` format as well after changing
>> its customization type to:
>>
>>   :type '(choice (const :tag "No special key to exit repeating sequence" nil)
>>                  (string :tag "Kbd string that exits repeating sequence")
>>                  (key-sequence :tag "Key that exits repeating sequence"))
>>
>> This assumes that `key-sequence` can't be a string.
>
> `key-sequence` can definitely be a string.

This means they can be used together.  So I just replaced
`key-sequence` with `key`, and added backward-compatibility code.

>> After that you could use (key-parse repeat-exit-key) to append it
>> to unread-command-events.
>
> `key-parse` returns a ... key-sequence, so it's of no help to Raman's
> "problem".

I believe the new function repeat-exit will help Raman in another way.

Re: keymap.el and its checks

[Stefan Monnier]

>>> After that you could use (key-parse repeat-exit-key) to append it
>>> to unread-command-events.
>>
>> `key-parse` returns a ... key-sequence, so it's of no help to Raman's
>> "problem".
>
> I believe the new function repeat-exit will help Raman in another way.

Yes, that looks like a more straightforward solution that messing around
with `unread-command-events` or changing timers's deadlines.


        Stefan