From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andrew Cohen <acohen@ust.hk>
Cc: emacs-devel@gnu.org
Subject: Re: News from the lexical world
Date: Thu, 29 Apr 2021 18:06:47 -0400 [thread overview]
Message-ID: <jwvim44dagv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <877dkor5bh.fsf@ust.hk> (Andrew Cohen's message of "Tue, 27 Apr 2021 07:31:30 +0800")
> But I guess this is a more generic problem? Any function added to
> sc-attribs-postselect-hook will need access to 'attribution and/or
> 'citation which are not in scope.
Indeed, I see now that it's documented in the docstring of
`sc-select-attribution`.
I installed the patch below which should fix it. Please confirm.
Stefan
diff --git a/lisp/mail/supercite.el b/lisp/mail/supercite.el
index dc1c641052b..d545b0c3f15 100644
--- a/lisp/mail/supercite.el
+++ b/lisp/mail/supercite.el
@@ -1128,6 +1128,8 @@ sc-select-attribution
auto-selected citation string and the variable `attribution' is bound
to the auto-selected attribution string."
(run-hooks 'sc-attribs-preselect-hook)
+ (with-suppressed-warnings ((lexical citation attribution))
+ (defvar citation) (defvar attribution))
(let ((query-p sc-confirm-always-p)
attribution citation
(attriblist sc-preferred-attribution-list))
next prev parent reply other threads:[~2021-04-29 22:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 16:23 News from the lexical world Stefan Monnier
2021-02-12 16:49 ` Stefan Kangas
2021-02-13 11:06 ` Lars Ingebrigtsen
2021-02-12 21:37 ` Andrea Corallo via Emacs development discussions.
2021-02-15 19:18 ` Phillip Lord
2021-04-10 21:32 ` Stefan Monnier
2021-04-11 6:37 ` Lars Ingebrigtsen
2021-04-11 7:20 ` Andrea Corallo via Emacs development discussions.
2021-04-11 13:44 ` T.V Raman
2021-04-11 14:39 ` Stefan Monnier
2021-04-11 15:10 ` T.V Raman
2021-04-11 15:42 ` Eli Zaretskii
2021-04-11 16:34 ` Stefan Monnier
2021-04-12 8:34 ` Andrea Corallo via Emacs development discussions.
2021-04-12 11:58 ` Eli Zaretskii
2021-04-12 12:58 ` Andrea Corallo via Emacs development discussions.
2021-04-12 13:23 ` Stefan Kangas
2021-04-12 13:24 ` Eli Zaretskii
2021-04-26 6:47 ` Andrew Cohen
2021-04-26 10:08 ` Stefan Kangas
2021-04-26 12:06 ` Andrew Cohen
2021-04-26 16:06 ` Stefan Monnier
2021-04-26 23:31 ` Andrew Cohen
2021-04-29 22:06 ` Stefan Monnier [this message]
2021-04-30 0:17 ` Andrew Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvim44dagv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acohen@ust.hk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).