From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: News from the lexical world Date: Thu, 29 Apr 2021 18:06:47 -0400 Message-ID: References: <87o8e1pmog.fsf@ust.hk> <87v989qmg4.fsf@ust.hk> <877dkor5bh.fsf@ust.hk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16452"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andrew Cohen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 30 00:07:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcEos-00049F-N2 for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Apr 2021 00:07:38 +0200 Original-Received: from localhost ([::1]:50560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcEor-0003q4-Rr for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 18:07:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcEo9-0003QA-Ae for emacs-devel@gnu.org; Thu, 29 Apr 2021 18:06:53 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcEo7-0008TY-GW for emacs-devel@gnu.org; Thu, 29 Apr 2021 18:06:53 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0425944145F; Thu, 29 Apr 2021 18:06:50 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9B1D8441456; Thu, 29 Apr 2021 18:06:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619734008; bh=/YRBW0B16Jt3FYn/hAuGVCugYG/+83gND4V5+QE8pkU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BGgQUxGi2P7Et+lCVozjuDfwBWl4dIOb/FfbkjUbnUE4x+SMl4lIKMurUPe+PVzP8 HtBNPhaMiGxNtBo225P23lSpnhBoymdVlc8J+voIiU/XESe3p8hz+wcCm41dNfmlPQ 0siAp2Lfc/Qm57UgiVkGU1se272mrcryMSJf5rKXTffQfp7OZXkBot4UjoKpUqqen5 pJqKjX11wrzqhP6qgH7wTPoEpTVdbv9pATnYf7cwZxFbgLztIjJVQbwuxNmIT1Ef3j i1NZulpvWopWJNBw2jQjnVZtTOX0ZJB19zw00ppTPaK8xuP6oU85rn1s5LQi0OzdN1 oaBywEnHBNsFA== Original-Received: from alfajor (unknown [108.161.125.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 682A31202DA; Thu, 29 Apr 2021 18:06:48 -0400 (EDT) In-Reply-To: <877dkor5bh.fsf@ust.hk> (Andrew Cohen's message of "Tue, 27 Apr 2021 07:31:30 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268640 Archived-At: > But I guess this is a more generic problem? Any function added to > sc-attribs-postselect-hook will need access to 'attribution and/or > 'citation which are not in scope. Indeed, I see now that it's documented in the docstring of `sc-select-attribution`. I installed the patch below which should fix it. Please confirm. Stefan diff --git a/lisp/mail/supercite.el b/lisp/mail/supercite.el index dc1c641052b..d545b0c3f15 100644 --- a/lisp/mail/supercite.el +++ b/lisp/mail/supercite.el @@ -1128,6 +1128,8 @@ sc-select-attribution auto-selected citation string and the variable `attribution' is bound to the auto-selected attribution string." (run-hooks 'sc-attribs-preselect-hook) + (with-suppressed-warnings ((lexical citation attribution)) + (defvar citation) (defvar attribution)) (let ((query-p sc-confirm-always-p) attribution citation (attriblist sc-preferred-attribution-list))