From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Po Lu <luangruo@yahoo.com>
Cc: Jashank Jeremy <jashank@rulingia.com.au>,
Emacs development list <emacs-devel@gnu.org>
Subject: Re: master e465ea816d: Don't unnecessarily call monitor change functions
Date: Sun, 22 May 2022 08:59:54 -0400 [thread overview]
Message-ID: <jwvh75hk9l0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87v8tyqaxh.fsf@yahoo.com> (Po Lu's message of "Sun, 22 May 2022 15:32:58 +0800")
Po Lu [2022-05-22 15:32:58] wrote:
> Jashank Jeremy <jashank@rulingia.com.au> writes:
>> .../emacs/src/src/xterm.c:20162:4: error: statement requires expression of
>> scalar type ('Lisp_Object' (aka 'struct Lisp_Object') invalid)
>> if (Fequal (current_monitors,
>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
> Thanks for catching the bug.
I recommend to anyone working on the C code to compile with
`--enable-check-lisp-object-type` so they'll see those errors before
they push them to `master`.
Stefan
prev parent reply other threads:[~2022-05-22 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 6:42 master e465ea816d: Don't unnecessarily call monitor change functions Jashank Jeremy
2022-05-22 7:32 ` Po Lu
2022-05-22 12:59 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvh75hk9l0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jashank@rulingia.com.au \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).