From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master e465ea816d: Don't unnecessarily call monitor change functions Date: Sun, 22 May 2022 08:59:54 -0400 Message-ID: References: <87wneef4pa.wl-jashank@rulingia.com.au> <87v8tyqaxh.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Jashank Jeremy , Emacs development list To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 22 15:02:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nslEV-00033H-9v for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 15:02:55 +0200 Original-Received: from localhost ([::1]:48194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nslET-0004Km-RS for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 09:02:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nslBh-00036V-Ha for emacs-devel@gnu.org; Sun, 22 May 2022 09:00:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nslBe-0000Ni-H6 for emacs-devel@gnu.org; Sun, 22 May 2022 09:00:00 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2B9E84421F6; Sun, 22 May 2022 08:59:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 135904421F4; Sun, 22 May 2022 08:59:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1653224396; bh=nJBaOOn86759/z8Z59khsM1qNdJeb73/ABtY3RI/cR8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lpHnRP1QW3VpRqdnuP+QU6PuFdxxPGBlE/H+07hxyyYbbNrgJJWuiXkp6dxcCfFHl P2P95+EbCQKyxCf3fsBcc5XMahiZcP8buX42tlgIwdQ+5MmcPOKeeF5K7gS/FsRI+f nUCVWFpxWS7Sav5lvbjuh3IWfBooHE3MXxLCB16bsA1OGxVCRBp3/ffCTu6egWi9zs ExrujdwDEmDTMbHDq8CVlpxNb0X027A56jeLFjAIGDqiDI+QNRkFjk7V8B+mK2gFKk cnP8Bku0vMA1NwIa2SDHz0GPu5BBtqbKCDlmJFLC9BYQYN74rVJgh6oFrekLkHj7+N eNaog8B/0jGLA== Original-Received: from ceviche (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D74851202E6; Sun, 22 May 2022 08:59:55 -0400 (EDT) In-Reply-To: <87v8tyqaxh.fsf@yahoo.com> (Po Lu's message of "Sun, 22 May 2022 15:32:58 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290093 Archived-At: Po Lu [2022-05-22 15:32:58] wrote: > Jashank Jeremy writes: >> .../emacs/src/src/xterm.c:20162:4: error: statement requires expression of >> scalar type ('Lisp_Object' (aka 'struct Lisp_Object') invalid) >> if (Fequal (current_monitors, >> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ > Thanks for catching the bug. I recommend to anyone working on the C code to compile with `--enable-check-lisp-object-type` so they'll see those errors before they push them to `master`. Stefan