unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Native display of line numbers, improved
Date: Mon, 26 Jun 2017 11:28:23 -0400	[thread overview]
Message-ID: <jwvd19q93ly.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 83podqsst5.fsf@gnu.org

Hi Eli,

I don't understand your comment: Alex is referring here to the approach
used in nlinum, which I chose specifically to avoid having to scan the
whole buffer.

Basically, start with a small value of display-line-number-width, and if
during display we find that this value is too small to fit the largest
displayed line-number, we increase it.  So when you open a very large
buffer (but where only the first 60 lines are displayed), only 2 columns
will be used for line-numbers since "it's been enough so far"; if you
move to line 2000 and back, we'll now be using 4 columns (even though
2 would be sufficient).  This means that column 0 does sometimes change,
but fairly rarely (only when you move to a line number with more digits
than what you've visited so far).


        Stefan


>> >> 1. An option to never dynamically shrink 'display-line-number-width'
>> >>    while still dynamically growing. I dislike having column 0 constantly
>> >>    changing, so an option to only grow the width dynamically like in
>> >>    (n)linum would be very appreciated.
>> >
>> > How is growing different from shrinking?  Just wondering.
>> 
>> Growing is necessary in the case where the width of the new line(s)
>> exceeds the current 'display-line-number-width'. Of course that can
>> be worked around by setting 'display-line-number-width' to a
>> sufficiently large number, but I would like it to be no larger than what
>> it needs to be for the current text in the buffer.

> You could do that by counting lines in the buffer in some suitable
> hook, and then setting the value of 'display-line-number-width'
> accordingly, right?

> My point is that doing what you want requires counting lines in the
> entire buffer, something that could take a considerable time.  So
> doing that in the display code when people who'd like that could set
> that up for them using the existing facilities sounds uneconomical.






  reply	other threads:[~2017-06-26 15:28 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-24 17:27 Native display of line numbers, improved Eli Zaretskii
2017-06-24 18:40 ` Clément Pit-Claudel
2017-06-24 18:51   ` Eli Zaretskii
2017-06-24 20:53 ` Stephen Berman
2017-06-25 14:07   ` Eli Zaretskii
2017-06-25 14:34     ` Stephen Berman
2017-06-25 15:10       ` Eli Zaretskii
2017-06-25 15:41         ` Stephen Berman
2017-06-25 16:02           ` Eli Zaretskii
2017-06-25 19:00             ` Stephen Berman
2017-06-24 21:23 ` Stephen Berman
2017-06-25 14:03   ` Eli Zaretskii
2017-06-25 14:34     ` Stephen Berman
2017-06-25 14:57       ` Eli Zaretskii
2017-07-17 22:20       ` line-number-mode at EOB (was: Native display of line numbers, improved) Stephen Berman
2017-07-18  4:16         ` line-number-mode at EOB Stefan Monnier
2017-07-18 14:04           ` Stephen Berman
2017-07-18 14:30             ` Stefan Monnier
2017-07-18 14:51               ` Eli Zaretskii
2017-07-18 15:04                 ` Stefan Monnier
2017-07-20 20:25                   ` Paul Eggert
2017-07-20 20:43                     ` Stephen Berman
2017-07-20 21:19                       ` Paul Eggert
2017-07-20 21:35                         ` Stephen Berman
2017-07-18 14:55         ` line-number-mode at EOB (was: Native display of line numbers, improved) Eli Zaretskii
2017-07-18 16:33           ` line-number-mode at EOB Stephen Berman
2017-07-18 19:03             ` Eli Zaretskii
2017-07-18 20:38               ` Stephen Berman
2017-06-25  9:59 ` Native display of line numbers, improved martin rudalics
2017-06-25 13:54   ` Eli Zaretskii
2017-06-25 15:58     ` martin rudalics
2017-06-25 20:30 ` Alex
2017-06-26  2:39   ` Eli Zaretskii
2017-06-26  3:43     ` Alex
2017-06-26  3:50       ` Alex
2017-06-26 14:58         ` Eli Zaretskii
2017-06-26 19:41           ` Alex
2017-06-27 14:25             ` Eli Zaretskii
2017-06-29 20:25               ` Native line numbers column disappears at times Kaushal Modi
2017-06-30  6:00                 ` Eli Zaretskii
2017-07-10 18:53                   ` Kaushal Modi
2017-07-10 19:31                     ` Eli Zaretskii
2017-07-10 20:56                       ` Kaushal Modi
2017-06-26 14:54       ` Native display of line numbers, improved Eli Zaretskii
2017-06-26 15:28         ` Stefan Monnier [this message]
2017-06-26 15:56           ` Eli Zaretskii
2017-06-26 16:12             ` Stefan Monnier
2017-06-26 16:26               ` Eli Zaretskii
2017-06-26 19:36             ` Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd19q93ly.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).