From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Native display of line numbers, improved Date: Mon, 26 Jun 2017 11:28:23 -0400 Message-ID: References: <83tw35thxw.fsf@gnu.org> <87efu7lsj0.fsf@lylat> <83r2y7sc9q.fsf@gnu.org> <87a84vl8gm.fsf@lylat> <83podqsst5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1498490932 29510 195.159.176.226 (26 Jun 2017 15:28:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Jun 2017 15:28:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 26 17:28:48 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPVwS-0007Mk-40 for ged-emacs-devel@m.gmane.org; Mon, 26 Jun 2017 17:28:44 +0200 Original-Received: from localhost ([::1]:47206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPVwX-0005sE-Cy for ged-emacs-devel@m.gmane.org; Mon, 26 Jun 2017 11:28:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPVwN-0005qj-4l for emacs-devel@gnu.org; Mon, 26 Jun 2017 11:28:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPVwJ-0001xm-U9 for emacs-devel@gnu.org; Mon, 26 Jun 2017 11:28:39 -0400 Original-Received: from [195.159.176.226] (port=40940 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dPVwJ-0001xa-Nc for emacs-devel@gnu.org; Mon, 26 Jun 2017 11:28:35 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dPVw8-0006S7-5t for emacs-devel@gnu.org; Mon, 26 Jun 2017 17:28:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 43 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:qBUrIQatEvnrJ4OBTegciCQ+u0c= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215997 Archived-At: Hi Eli, I don't understand your comment: Alex is referring here to the approach used in nlinum, which I chose specifically to avoid having to scan the whole buffer. Basically, start with a small value of display-line-number-width, and if during display we find that this value is too small to fit the largest displayed line-number, we increase it. So when you open a very large buffer (but where only the first 60 lines are displayed), only 2 columns will be used for line-numbers since "it's been enough so far"; if you move to line 2000 and back, we'll now be using 4 columns (even though 2 would be sufficient). This means that column 0 does sometimes change, but fairly rarely (only when you move to a line number with more digits than what you've visited so far). Stefan >> >> 1. An option to never dynamically shrink 'display-line-number-width' >> >> while still dynamically growing. I dislike having column 0 constantly >> >> changing, so an option to only grow the width dynamically like in >> >> (n)linum would be very appreciated. >> > >> > How is growing different from shrinking? Just wondering. >> >> Growing is necessary in the case where the width of the new line(s) >> exceeds the current 'display-line-number-width'. Of course that can >> be worked around by setting 'display-line-number-width' to a >> sufficiently large number, but I would like it to be no larger than what >> it needs to be for the current text in the buffer. > You could do that by counting lines in the buffer in some suitable > hook, and then setting the value of 'display-line-number-width' > accordingly, right? > My point is that doing what you want requires counting lines in the > entire buffer, something that could take a considerable time. So > doing that in the display code when people who'd like that could set > that up for them using the existing facilities sounds uneconomical.