Re: master a3b3130 1/2: Fix cursor movement on the Linux console with certain characters

Re: master a3b3130 1/2: Fix cursor movement on the Linux console with certain characters

[Stefan Monnier]

>     Fix cursor movement on the Linux console with certain characters
[...]
> +  ;; Compositions confuse cursor movement.
> +  (global-auto-composition-mode -1)

While disabling composition in `linux` terminals makes sense, the above
code disables them in all frames, not just those attached to
`linux` terminals.


        Stefan

Re: master a3b3130 1/2: Fix cursor movement on the Linux console with certain characters

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>     Fix cursor movement on the Linux console with certain characters
> [...]
>> +  ;; Compositions confuse cursor movement.
>> +  (global-auto-composition-mode -1)
>
> While disabling composition in `linux` terminals makes sense, the above
> code disables them in all frames, not just those attached to
> `linux` terminals.

(In all frames if you have a frame on a Linux console, I think?  Or did
I misunderstand how term/* stuff works?)

We're discussing how to make this work better over at bug#21363.  I'm
wondering whether altering global-auto-composition-mode to respect a
predicate function (to only switch it on on the console), but
`auto-composition-mode' is a per-buffer thing, and you may open the
buffer on a different frame, then display it on the console, and then
that won't work either...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master a3b3130 1/2: Fix cursor movement on the Linux console with certain characters

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 16 Aug 2021 20:53:54 +0200
> Cc: emacs-devel@gnu.org
> 
> > While disabling composition in `linux` terminals makes sense, the above
> > code disables them in all frames, not just those attached to
> > `linux` terminals.
> 
> (In all frames if you have a frame on a Linux console, I think?  Or did
> I misunderstand how term/* stuff works?)
> 
> We're discussing how to make this work better over at bug#21363.  I'm
> wondering whether altering global-auto-composition-mode to respect a
> predicate function (to only switch it on on the console), but
> `auto-composition-mode' is a per-buffer thing, and you may open the
> buffer on a different frame, then display it on the console, and then
> that won't work either...

We could perhaps introduce a new, non-nil, non-t value of
auto-composition-mode which would internally cause the display code to
test the current terminal?

Re: master a3b3130 1/2: Fix cursor movement on the Linux console with certain characters

[Stefan Monnier]

>> While disabling composition in `linux` terminals makes sense, the above
>> code disables them in all frames, not just those attached to
>> `linux` terminals.
> (In all frames if you have a frame on a Linux console, I think?

Yup.

> We're discussing how to make this work better over at bug#21363.  I'm
> wondering whether altering global-auto-composition-mode to respect a
> predicate function (to only switch it on on the console), but
> `auto-composition-mode' is a per-buffer thing, and you may open the
> buffer on a different frame, then display it on the console, and then
> that won't work either...

Ah, right, it's per-buffer :-(


        Stefan

Re: master a3b3130 1/2: Fix cursor movement on the Linux console with certain characters

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> We could perhaps introduce a new, non-nil, non-t value of
> auto-composition-mode which would internally cause the display code to
> test the current terminal?

Yes, that could work (and would be a change localised to composite.c, so
it shouldn't be too messy).

Now pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no