* Re: [elpa] scratch/javaimp-wip 606cb3f08a: *** empty log message ***
[not found] ` <20220415130416.0F774C01684@vcs2.savannah.gnu.org>
@ 2022-04-15 14:09 ` Stefan Monnier
2022-04-16 15:03 ` Filipp Gunbin
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2022-04-15 14:09 UTC (permalink / raw)
To: Filipp Gunbin; +Cc: emacs-devel
Filipp Gunbin [2022-04-15 09:04:15] wrote:
> branch: scratch/javaimp-wip
> commit 606cb3f08a10bf5e6571657fbec6b13f019a5ead
> Author: Filipp Gunbin <fgunbin@okko.tv>
> Commit: Filipp Gunbin <fgunbin@okko.tv>
>
> *** empty log message ***
> ---
> javaimp-parse.el | 4 +--
> javaimp-util.el | 7 +++++
> javaimp.el | 86 ++++++++++++++++++++++++++++++++++++--------------------
> 3 files changed, 65 insertions(+), 32 deletions(-)
While we do not require that GNU ELPA packages follow the conventions we
use for Emacs's commit messages, I recommend you avoid empty commit
messages like the one above. The extra time it takes to briefly
describe what the change intends to do always pays off in the long run.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] scratch/javaimp-wip 606cb3f08a: *** empty log message ***
2022-04-15 14:09 ` [elpa] scratch/javaimp-wip 606cb3f08a: *** empty log message *** Stefan Monnier
@ 2022-04-16 15:03 ` Filipp Gunbin
2022-04-16 15:22 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Filipp Gunbin @ 2022-04-16 15:03 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Hi Stefan,
On 15/04/2022 10:09 -0400, Stefan Monnier wrote:
> Filipp Gunbin [2022-04-15 09:04:15] wrote:
>
>> branch: scratch/javaimp-wip
>> commit 606cb3f08a10bf5e6571657fbec6b13f019a5ead
>> Author: Filipp Gunbin <fgunbin@okko.tv>
>> Commit: Filipp Gunbin <fgunbin@okko.tv>
>>
>> *** empty log message ***
>> ---
>> javaimp-parse.el | 4 +--
>> javaimp-util.el | 7 +++++
>> javaimp.el | 86 ++++++++++++++++++++++++++++++++++++--------------------
>> 3 files changed, 65 insertions(+), 32 deletions(-)
>
> While we do not require that GNU ELPA packages follow the conventions we
> use for Emacs's commit messages, I recommend you avoid empty commit
> messages like the one above. The extra time it takes to briefly
> describe what the change intends to do always pays off in the long run.
It's a scratch branch, as the name says, and I'll later squash commits,
provide some message, and push to the normal branch :-)
Filipp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] scratch/javaimp-wip 606cb3f08a: *** empty log message ***
2022-04-16 15:03 ` Filipp Gunbin
@ 2022-04-16 15:22 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2022-04-16 15:22 UTC (permalink / raw)
To: Filipp Gunbin; +Cc: emacs-devel
> It's a scratch branch, as the name says,
Duh, sorry I missed this "detail".
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-16 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165002785573.5136.10116060336325498349@vcs2.savannah.gnu.org>
[not found] ` <20220415130416.0F774C01684@vcs2.savannah.gnu.org>
2022-04-15 14:09 ` [elpa] scratch/javaimp-wip 606cb3f08a: *** empty log message *** Stefan Monnier
2022-04-16 15:03 ` Filipp Gunbin
2022-04-16 15:22 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).