unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 69cd21222a 1/2: * etc/themes/leuven-dark-theme.el: Use lexical-binding
@ 2022-05-26 20:00 Eli Zaretskii
  2022-05-26 20:28 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2022-05-26 20:00 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

> branch: master
> commit 69cd21222a43ff0144ab7fef51ba23de246209cc
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> 
>     * etc/themes/leuven-dark-theme.el: Use lexical-binding

The commit log message says "Use lexical-binding", but the actual
change does more than that, without any rationale, not even in the
comments.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master 69cd21222a 1/2: * etc/themes/leuven-dark-theme.el: Use lexical-binding
  2022-05-26 20:00 master 69cd21222a 1/2: * etc/themes/leuven-dark-theme.el: Use lexical-binding Eli Zaretskii
@ 2022-05-26 20:28 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2022-05-26 20:28 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii [2022-05-26 23:00:01] wrote:
>>     * etc/themes/leuven-dark-theme.el: Use lexical-binding
> The commit log message says "Use lexical-binding", but the actual
> change does more than that, without any rationale, not even in the
> comments.

Hmm.. apparently I managed to erase the second line, which said:

    Comment out unused vars `clock-line` and `highlight-(blue2,green,red)`.


-- Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-26 20:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 20:00 master 69cd21222a 1/2: * etc/themes/leuven-dark-theme.el: Use lexical-binding Eli Zaretskii
2022-05-26 20:28 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).