From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Proposal: 'struct window' cleanup
Date: Tue, 22 May 2012 08:39:42 -0400 [thread overview]
Message-ID: <jwvaa10z916.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4FBB3B62.4070504@yandex.ru> (Dmitry Antipov's message of "Tue, 22 May 2012 11:08:18 +0400")
>> I generally like the idea. But please don't use "_p" suffixes
>> for variables. The "p" stands for "predicate" and a predicate is a kind
>> of function, so that's not the right way to say that something is
>> a boolean value.
> OK, but what about other "struct window" bitfield members whose names
> ends with "_p"?
Yes, I know, just like many Elisp packages use vars with names ending in
"-p" for the same mistaken reason.
> Should we also rename it to obey this naming convention?
No, it's not worth the trouble.
> Also this kind of patch proposes a lot of small and simple changes.
> Is there a convenient way to document them in ChangeLog?
I'd do it like
* foo.h (struct bar): Use bitfields for field1, field2, field3.
Adjust users accordingly.
-- Stefan
next prev parent reply other threads:[~2012-05-22 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 14:25 Proposal: 'struct window' cleanup Dmitry Antipov
2012-05-21 14:37 ` Davis Herring
2012-05-22 3:30 ` Stefan Monnier
2012-05-22 7:08 ` Dmitry Antipov
2012-05-22 7:40 ` Thien-Thi Nguyen
2012-05-22 12:39 ` Stefan Monnier [this message]
2012-05-23 4:49 ` Dmitry Antipov
2012-05-23 14:23 ` Stefan Monnier
2012-06-01 3:46 ` Dmitry Antipov
2012-06-01 17:29 ` Stefan Monnier
2012-05-22 16:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvaa10z916.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).