From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Proposal: 'struct window' cleanup Date: Tue, 22 May 2012 08:39:42 -0400 Message-ID: References: <4FBA5060.7070702@yandex.ru> <4FBB3B62.4070504@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337690404 21035 80.91.229.3 (22 May 2012 12:40:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 22 May 2012 12:40:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 22 14:40:03 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SWoNc-00033n-0m for ged-emacs-devel@m.gmane.org; Tue, 22 May 2012 14:40:00 +0200 Original-Received: from localhost ([::1]:49280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWoNb-0000PT-Gg for ged-emacs-devel@m.gmane.org; Tue, 22 May 2012 08:39:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWoNU-0000OT-4P for emacs-devel@gnu.org; Tue, 22 May 2012 08:39:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWoNO-0001M3-A5 for emacs-devel@gnu.org; Tue, 22 May 2012 08:39:51 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:5247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWoNO-0001LG-5t for emacs-devel@gnu.org; Tue, 22 May 2012 08:39:46 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAOMAh0/O+K+j/2dsb2JhbAA3o0KBCIF1AQEEAVYjBQsLDiYSFBgNJIgTohGMIQY9CQMDgz4Dg3AEo2OEWA X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="181736561" Original-Received: from 206-248-175-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.175.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 May 2012 08:39:43 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 11FFB59198; Tue, 22 May 2012 08:39:42 -0400 (EDT) In-Reply-To: <4FBB3B62.4070504@yandex.ru> (Dmitry Antipov's message of "Tue, 22 May 2012 11:08:18 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.143.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150605 Archived-At: >> I generally like the idea. But please don't use "_p" suffixes >> for variables. The "p" stands for "predicate" and a predicate is a kind >> of function, so that's not the right way to say that something is >> a boolean value. > OK, but what about other "struct window" bitfield members whose names > ends with "_p"? Yes, I know, just like many Elisp packages use vars with names ending in "-p" for the same mistaken reason. > Should we also rename it to obey this naming convention? No, it's not worth the trouble. > Also this kind of patch proposes a lot of small and simple changes. > Is there a convenient way to document them in ChangeLog? I'd do it like * foo.h (struct bar): Use bitfields for field1, field2, field3. Adjust users accordingly. -- Stefan