From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ergus <spacibba@aol.com>
Cc: emacs-devel@gnu.org
Subject: Re: Uniquify change [PATCH]
Date: Sun, 13 Sep 2020 15:02:44 -0400 [thread overview]
Message-ID: <jwva6xt8pvl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200912115007.tze35edwcdo5vdoc@Ergus> (Ergus's message of "Sat, 12 Sep 2020 13:50:07 +0200")
> I want to add this patch to master. Could you give it a look and suggest
> where in NEWS I should mention this?
Looks very good to me. See below for the nitpicks,
> diff --git a/lisp/uniquify.el b/lisp/uniquify.el
> index 70e8ecee74..8439d9d874 100644
> --- a/lisp/uniquify.el
> +++ b/lisp/uniquify.el
> @@ -104,6 +104,13 @@ uniquify-buffer-name-style
> post-forward-angle-brackets name<bar/mumble> name<quux/mumble>
> nil name name<2>
>
> +The value can be set to a customized function with two mandatory
> +arguments. For example the current implementation for
> +post-forward-angle-brackets could be:
You should describe those arguments rather than only tell the number of
args and show an example. E.g.
The value can be set to a customized function which will be called
two arguments BASE and EXTRA-STRINGS where BASE is a string and
EXTRA-STRINGS is a list of strings. For example the current
implementation for post-forward-angle-brackets could be:
> +(defun my-post-forward-angle-brackets (base extra-string)
> + (concat base \"<\" (mapconcat 'identity extra-string \"/\") \">\"))
I'd use #' rather than ' to quote `identity`.
Stefan
next prev parent reply other threads:[~2020-09-13 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200912115007.tze35edwcdo5vdoc.ref@Ergus>
2020-09-12 11:50 ` Uniquify change [PATCH] Ergus
2020-09-13 19:02 ` Stefan Monnier [this message]
2020-09-15 11:34 ` Ergus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva6xt8pvl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).