From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Uniquify change [PATCH] Date: Sun, 13 Sep 2020 15:02:44 -0400 Message-ID: References: <20200912115007.tze35edwcdo5vdoc.ref@Ergus> <20200912115007.tze35edwcdo5vdoc@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10937"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 21:03:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHXHu-0002lC-EC for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 21:03:46 +0200 Original-Received: from localhost ([::1]:55252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHXHt-0005mc-AE for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 15:03:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXHM-0005Lf-W3 for emacs-devel@gnu.org; Sun, 13 Sep 2020 15:03:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXHK-0005Aj-Qq for emacs-devel@gnu.org; Sun, 13 Sep 2020 15:03:12 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B5BDB804EC; Sun, 13 Sep 2020 15:03:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7C02F8009D; Sun, 13 Sep 2020 15:02:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600023765; bh=TYgHpJ6KMwrodiJkaYG/l3DQXCGrq5xnPmr98szSP7Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=n3Ip1gM/9FLQn3uJR/KA0vGi5s16UKNZjZ33ZD0lutEsjjFWKRyzlkKlFUhkj0pEI IjLXSD5X2Xcm5N+PsPtIzli9VrsE0xpdf66FLX6dhrGWLAoxQWl+pAhDpmcmuJ4VAp t7GoSVSj1vPp4BjQ+myrqWJOxj02YHeHWYXgP1C6W7Watw+/HqOmL+X+Y9kaxmkMDa xjvjmi0Q7iVn/LRlmLTFJhUYVxzS27or4OTIPJ2Gc0wDaKXOYvQD+MnyrQycBYmtLW wtj//IbBOCeBHH+Sk88M7uFou7GqQnqDg9xQWTFhV3KmCl47o+5T80pcXWzaRSzrBk yysbXOektWZfQ== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4CA1F1203E4; Sun, 13 Sep 2020 15:02:45 -0400 (EDT) In-Reply-To: <20200912115007.tze35edwcdo5vdoc@Ergus> (Ergus's message of "Sat, 12 Sep 2020 13:50:07 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 15:03:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255560 Archived-At: > I want to add this patch to master. Could you give it a look and suggest > where in NEWS I should mention this? Looks very good to me. See below for the nitpicks, > diff --git a/lisp/uniquify.el b/lisp/uniquify.el > index 70e8ecee74..8439d9d874 100644 > --- a/lisp/uniquify.el > +++ b/lisp/uniquify.el > @@ -104,6 +104,13 @@ uniquify-buffer-name-style > post-forward-angle-brackets name name > nil name name<2> > > +The value can be set to a customized function with two mandatory > +arguments. For example the current implementation for > +post-forward-angle-brackets could be: You should describe those arguments rather than only tell the number of args and show an example. E.g. The value can be set to a customized function which will be called two arguments BASE and EXTRA-STRINGS where BASE is a string and EXTRA-STRINGS is a list of strings. For example the current implementation for post-forward-angle-brackets could be: > +(defun my-post-forward-angle-brackets (base extra-string) > + (concat base \"<\" (mapconcat 'identity extra-string \"/\") \">\")) I'd use #' rather than ' to quote `identity`. Stefan