* Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.
[not found] ` <20220118075640.732BDC0DA31@vcs2.savannah.gnu.org>
@ 2022-01-18 13:17 ` Stefan Monnier
2022-01-18 13:28 ` Po Lu
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2022-01-18 13:17 UTC (permalink / raw)
To: emacs-devel; +Cc: Po Lu
> - (or (not (and haiku-use-system-tooltips
> - (eq window-system 'haiku)))
> + (or (not (and (eq window-system 'haiku)
> + haiku-use-system-tooltips))
Could you merge this var with `x-gtk-use-system-tooltips`, maybe into
a `use-system-tooltips` var which can be either nil t or a list of
window-systems on which it should be true?
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.
2022-01-18 13:17 ` master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo Stefan Monnier
@ 2022-01-18 13:28 ` Po Lu
2022-01-18 14:06 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Po Lu @ 2022-01-18 13:28 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Could you merge this var with `x-gtk-use-system-tooltips`, maybe into
> a `use-system-tooltips` var which can be either nil t or a list of
> window-systems on which it should be true?
I don't think the last option is necessary, since it will only take
effect on supported window systems, but otherwise that looks good to me.
Where do you think would be the best place to put such a variable
definition?
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.
2022-01-18 13:28 ` Po Lu
@ 2022-01-18 14:06 ` Stefan Monnier
2022-01-19 0:38 ` Po Lu
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2022-01-18 14:06 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
> I don't think the last option is necessary, since it will only take
> effect on supported window systems, but otherwise that looks good to me.
You're probably right.
> Where do you think would be the best place to put such a variable
> definition?
`tooltip.el` seems like the obvious choice.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.
2022-01-18 14:06 ` Stefan Monnier
@ 2022-01-19 0:38 ` Po Lu
2022-01-19 3:30 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Po Lu @ 2022-01-19 0:38 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> `tooltip.el` seems like the obvious choice.
It has to be in C though. Perhaps keyboard.c or frame.c would make more
sense. WDYT?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.
2022-01-19 0:38 ` Po Lu
@ 2022-01-19 3:30 ` Stefan Monnier
2022-01-19 4:48 ` Po Lu
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2022-01-19 3:30 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu [2022-01-19 08:38:01] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> `tooltip.el` seems like the obvious choice.
>
> It has to be in C though. Perhaps keyboard.c or frame.c would make more
> sense. WDYT?
I'm probably the wrong person for this choice because I don't have
a clear understanding of what goes where in this part of the code, but
I think there are worse choices than `syms_of_display`.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.
2022-01-19 3:30 ` Stefan Monnier
@ 2022-01-19 4:48 ` Po Lu
2022-01-19 5:14 ` Po Lu
0 siblings, 1 reply; 7+ messages in thread
From: Po Lu @ 2022-01-19 4:48 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I'm probably the wrong person for this choice because I don't have
> a clear understanding of what goes where in this part of the code, but
> I think there are worse choices than `syms_of_display`.
Hmm, I actually think it's more appropriate for frame.c (since tooltips
are usually a special kind of frame), so I'll put it there instead.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo.
2022-01-19 4:48 ` Po Lu
@ 2022-01-19 5:14 ` Po Lu
0 siblings, 0 replies; 7+ messages in thread
From: Po Lu @ 2022-01-19 5:14 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> I'm probably the wrong person for this choice because I don't have
>> a clear understanding of what goes where in this part of the code, but
>> I think there are worse choices than `syms_of_display`.
>
> Hmm, I actually think it's more appropriate for frame.c (since tooltips
> are usually a special kind of frame), so I'll put it there instead.
>
> Thanks.
Now done.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-19 5:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <164249260014.5061.1349446051634551208@vcs2.savannah.gnu.org>
[not found] ` <20220118075640.732BDC0DA31@vcs2.savannah.gnu.org>
2022-01-18 13:17 ` master c99e28207a: * lisp/tooltip.el (tooltip-show-help): Fix typo Stefan Monnier
2022-01-18 13:28 ` Po Lu
2022-01-18 14:06 ` Stefan Monnier
2022-01-19 0:38 ` Po Lu
2022-01-19 3:30 ` Stefan Monnier
2022-01-19 4:48 ` Po Lu
2022-01-19 5:14 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).