File lisp/abbrevlist.el

File lisp/abbrevlist.el

[Leo]

I suggest obsolete/remove file lisp/abbrevlist.el since it contains a
single broken function that nobody seems to use.

Leo

Re: File lisp/abbrevlist.el

[Andreas Röhler]

Am 23.03.2011 02:15, schrieb Leo:
> I suggest obsolete/remove file lisp/abbrevlist.el since it contains a
> single broken function that nobody seems to use.
>
> Leo
>
>
>

Hi Leo,

would consider it a potentially useful function though.
Maybe put it into abbrev.el?

BTW what I missed is a way to get the right abbrev table when editing.

Solved that here locally meanwhile and may provide the code.

For example in Emacs-lisp-mode would expext

emacs-lisp-mode-abbrev-table

while the right one to edit is called

lisp-mode-abbrev-table

emacs-lisp-mode-abbrev-table exists but is not queried by 
emacs-lisp-mode's abbrev-expand.

Maybe a bug?

Cheers

Re: File lisp/abbrevlist.el

[Leo]

On 2011-03-23 16:31 +0800, Andreas Röhler wrote:
> Hi Leo,
>
> would consider it a potentially useful function though.
> Maybe put it into abbrev.el?

I wonder if insert-abbrev-table-description does something similar
already?

Leo

Re: File lisp/abbrevlist.el

[Stefan Monnier]

> I suggest obsolete/remove file lisp/abbrevlist.el since it contains a
> single broken function that nobody seems to use.

Obsoleting it sounds good, yes.  In what way is it broken?


        Stefan

Re: File lisp/abbrevlist.el

[Leo]

On 2011-03-24 01:46 +0800, Stefan Monnier wrote:
> Obsoleting it sounds good, yes.  In what way is it broken?

I didn't investigate further but this backtrace:

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
  list-one-abbrev-table([ 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 ...] "abc")
  eval((list-one-abbrev-table text-mode-abbrev-table "abc"))
  eval-expression((list-one-abbrev-table text-mode-abbrev-table "abc") nil)
  call-interactively(eval-expression nil nil)

Leo

Re: File lisp/abbrevlist.el

[Leo]

On 2011-03-24 01:46 +0800, Stefan Monnier wrote:
> Obsoleting it sounds good, yes.

Done in revision 103734.

Leo

Re: File lisp/abbrevlist.el

[Andreas Röhler]

Am 23.03.2011 10:55, schrieb Leo:
> On 2011-03-23 16:31 +0800, Andreas Röhler wrote:
>> Hi Leo,
>>
>> would consider it a potentially useful function though.
>> Maybe put it into abbrev.el?
>
> I wonder if insert-abbrev-table-description does something similar
> already?
>
> Leo
>
>
>

Think you are right.
BTW list-one-abbrev-table seems to have a bug.

Best regards,

Andreas

Re: File lisp/abbrevlist.el

[Stefan Monnier]

>> Obsoleting it sounds good, yes.  In what way is it broken?
> I didn't investigate further but this backtrace:
> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
>   list-one-abbrev-table([ 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 ...]
> "abc")
>   eval((list-one-abbrev-table text-mode-abbrev-table "abc"))
>   eval-expression((list-one-abbrev-table text-mode-abbrev-table "abc") nil)
>   call-interactively(eval-expression nil nil)

Ah, yes, so it's broken since Emacs-23.1 (since the introduction of the
new Elisp implementation of abbrevs).  This probably means we can remove
it altogether.


        Stefan

Re: File lisp/abbrevlist.el

[Richard Stallman]

I created the file abbrevlist.el back when it was crucial to keep
the standard Emacs load as small as possible.  Logically that function
belonged in abbrev.el, but it didn't need to be preloaded as abbrev.el is.

-- 
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org, www.gnu.org
Skype: Don't use Skype, it's proprietary software!

Re: File lisp/abbrevlist.el

[Leo]

On 2011-03-24 04:38 +0800, Stefan Monnier wrote:
> Ah, yes, so it's broken since Emacs-23.1 (since the introduction of
> the new Elisp implementation of abbrevs).

Thus my claim 'nobody seems to use it' ;)

> This probably means we can remove it altogether.

I have already moved it to obsolete/. Do you want me to remove it
entirely?

Leo

Re: File lisp/abbrevlist.el

[Leo]

On 2011-03-24 03:47 +0800, Andreas Röhler wrote:
> BTW list-one-abbrev-table seems to have a bug.

Yes, it is broken for a while and nobody noticed.

Leo

Re: File lisp/abbrevlist.el

[Stefan Monnier]

> I have already moved it to obsolete/. Do you want me to remove it
> entirely?

Let's remove it in Emacs-25.


        Stfean