* Re: [Emacs-diffs] master 9278d90: * lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177).
[not found] ` <20170325232805.F309E20193@vcs0.savannah.gnu.org>
@ 2017-03-26 14:17 ` Stefan Monnier
2017-03-26 14:47 ` Paul Pogonyshev
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2017-03-26 14:17 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul Pogonyshev
> - (when data
> - (message "pcase-memoize: equal first branch, yet different"))
> + ;; (when data
> + ;; (message "pcase-memoize: equal first branch, yet different"))
I'm curious: where did you bump into it?
[ The reason I'm curious, is that it's basically detecting a bug in
pcase's memoization, so if you saw that message, we need to improve
it. ]
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 9278d90: * lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177).
2017-03-26 14:17 ` [Emacs-diffs] master 9278d90: * lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177) Stefan Monnier
@ 2017-03-26 14:47 ` Paul Pogonyshev
2017-03-27 0:26 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Paul Pogonyshev @ 2017-03-26 14:47 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Emacs developers
There is a testcase in the bugreport.
Paul
On 26 March 2017 at 16:17, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> - (when data
>> - (message "pcase-memoize: equal first branch, yet different"))
>> + ;; (when data
>> + ;; (message "pcase-memoize: equal first branch, yet different"))
>
> I'm curious: where did you bump into it?
> [ The reason I'm curious, is that it's basically detecting a bug in
> pcase's memoization, so if you saw that message, we need to improve
> it. ]
>
>
> Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 9278d90: * lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177).
2017-03-26 14:47 ` Paul Pogonyshev
@ 2017-03-27 0:26 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2017-03-27 0:26 UTC (permalink / raw)
To: Paul Pogonyshev; +Cc: Emacs developers
> There is a testcase in the bugreport.
Looking at the problem again, I see that your patch is fine:
I didn't remember, but indeed I fixed the code to be "conservative" in
the sense that we detect when the memoization doesn't give a useful
answer and we just fall back to "no memoization", which should be good
enough in most cases anyway (nowadays memoization is almost only useful
for bootstrap anyway).
Stefan
> On 26 March 2017 at 16:17, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>> - (when data
>>> - (message "pcase-memoize: equal first branch, yet different"))
>>> + ;; (when data
>>> + ;; (message "pcase-memoize: equal first branch, yet different"))
>>
>> I'm curious: where did you bump into it?
>> [ The reason I'm curious, is that it's basically detecting a bug in
>> pcase's memoization, so if you saw that message, we need to improve
>> it. ]
>>
>>
>> Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-27 0:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170325232804.11827.45077@vcs0.savannah.gnu.org>
[not found] ` <20170325232805.F309E20193@vcs0.savannah.gnu.org>
2017-03-26 14:17 ` [Emacs-diffs] master 9278d90: * lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177) Stefan Monnier
2017-03-26 14:47 ` Paul Pogonyshev
2017-03-27 0:26 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).