* No docstring slot for pcase--make-docstring
@ 2019-03-06 9:39 martin rudalics
2019-03-06 13:36 ` Michael Heerdegen
0 siblings, 1 reply; 15+ messages in thread
From: martin rudalics @ 2019-03-06 9:39 UTC (permalink / raw)
To: emacs-devel
When building master I currently see
Finding pointers to doc strings...
No docstring slot for pcase--make-docstring
Finding pointers to doc strings...done
Is this something I should care about?
Thanks in advance for enlightenment, martin
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-06 9:39 No docstring slot for pcase--make-docstring martin rudalics
@ 2019-03-06 13:36 ` Michael Heerdegen
2019-03-08 6:23 ` Stefan Monnier
2019-03-08 22:28 ` Stefan Monnier
0 siblings, 2 replies; 15+ messages in thread
From: Michael Heerdegen @ 2019-03-06 13:36 UTC (permalink / raw)
To: martin rudalics; +Cc: Stefan Monnier, emacs-devel
martin rudalics <rudalics@gmx.at> writes:
> When building master I currently see
>
> Finding pointers to doc strings...
> No docstring slot for pcase--make-docstring
> Finding pointers to doc strings...done
>
> Is this something I should care about?
Stefan (CC'd) had added autoload cookies to achieve that C-h f pcase
looks sane when pcase.el had not yet been loaded. pcase--make-docstring
is now autoloaded, but it's an internal helper and don't has, and
probably don't needs, a docstring. Yet Emacs complains because it's
autoloaded.
Is something like
(put 'pcase 'function-documentation
'(progn (require 'pcase) (pcase--make-docstring)))
an alternative to autoloading `pcase--make-docstring'?
Michael.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: No docstring slot for pcase--make-docstring
2019-03-06 13:36 ` Michael Heerdegen
@ 2019-03-08 6:23 ` Stefan Monnier
2019-03-08 22:28 ` Stefan Monnier
1 sibling, 0 replies; 15+ messages in thread
From: Stefan Monnier @ 2019-03-08 6:23 UTC (permalink / raw)
To: emacs-devel
>> Finding pointers to doc strings...
>> No docstring slot for pcase--make-docstring
>> Finding pointers to doc strings...done
I wonder why we get this message. AFAICT this message comes from
Snarf-documentation, but since pcase--make-docstring doesn't have
a docstring, it shouldn't appear in etc/DOC and hence shouldn't be
touched by Snarf-documentation.
...Oh, I see that the autoload does have a "dummy" docstring providing
the name of the arguments (tho here there are none, so it's really
silly) and for that reason pcase--make-docstring does appear in etc/DOC.
> (put 'pcase 'function-documentation
> '(progn (require 'pcase) (pcase--make-docstring)))
The warning is definitely harmless here (especially since AFAICT it only
appears when dumping `bootstrap-emacs` and not for the real `emacs`), so
this is not needed. Maybe we should fix the autoload to not have
a docstring, OTOH? Or maybe we shouldn't bother to Snarf-documentation
for bootstrap-emacs?
Stefan
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: No docstring slot for pcase--make-docstring
2019-03-06 13:36 ` Michael Heerdegen
2019-03-08 6:23 ` Stefan Monnier
@ 2019-03-08 22:28 ` Stefan Monnier
2019-03-09 9:08 ` martin rudalics
1 sibling, 1 reply; 15+ messages in thread
From: Stefan Monnier @ 2019-03-08 22:28 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: martin rudalics, emacs-devel
>> When building master I currently see
>>
>> Finding pointers to doc strings...
>> No docstring slot for pcase--make-docstring
>> Finding pointers to doc strings...done
>>
>> Is this something I should care about?
I believe this should be fixed now.
Stefan
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: No docstring slot for pcase--make-docstring
2019-03-08 22:28 ` Stefan Monnier
@ 2019-03-09 9:08 ` martin rudalics
2019-03-09 9:12 ` martin rudalics
0 siblings, 1 reply; 15+ messages in thread
From: martin rudalics @ 2019-03-09 9:08 UTC (permalink / raw)
To: Stefan Monnier, Michael Heerdegen; +Cc: emacs-devel
>>> Finding pointers to doc strings...
>>> No docstring slot for pcase--make-docstring
>>> Finding pointers to doc strings...done
>>>
>>> Is this something I should care about?
>
> I believe this should be fixed now.
It's still here after today's checkout.
martin
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-09 9:08 ` martin rudalics
@ 2019-03-09 9:12 ` martin rudalics
2019-03-09 9:46 ` martin rudalics
0 siblings, 1 reply; 15+ messages in thread
From: martin rudalics @ 2019-03-09 9:12 UTC (permalink / raw)
To: Stefan Monnier, Michael Heerdegen; +Cc: emacs-devel
> It's still here after today's checkout.
But apparently it disappeared after recompiling autoload.el. So it
seems to be fixed indeed.
Many thanks, martin
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-09 9:12 ` martin rudalics
@ 2019-03-09 9:46 ` martin rudalics
2019-03-09 10:48 ` Eli Zaretskii
0 siblings, 1 reply; 15+ messages in thread
From: martin rudalics @ 2019-03-09 9:46 UTC (permalink / raw)
To: Stefan Monnier, Michael Heerdegen; +Cc: emacs-devel
And it's here again.
Finding pointers to doc strings...
No docstring slot for pcase--make-docstring
Finding pointers to doc strings...done
Dumping under the name bootstrap-emacs.pdmp
dumping fingerprint: 62cb4fea729e5e096e667c1459564f7db0b4edba8329453a8ed0478dcc49389c
Dump complete
From my latest build of master.
martin, confused
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-09 9:46 ` martin rudalics
@ 2019-03-09 10:48 ` Eli Zaretskii
2019-03-09 13:15 ` martin rudalics
0 siblings, 1 reply; 15+ messages in thread
From: Eli Zaretskii @ 2019-03-09 10:48 UTC (permalink / raw)
To: martin rudalics; +Cc: michael_heerdegen, monnier, emacs-devel
> Date: Sat, 09 Mar 2019 10:46:20 +0100
> From: martin rudalics <rudalics@gmx.at>
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> And it's here again.
>
> Finding pointers to doc strings...
> No docstring slot for pcase--make-docstring
> Finding pointers to doc strings...done
> Dumping under the name bootstrap-emacs.pdmp
> dumping fingerprint: 62cb4fea729e5e096e667c1459564f7db0b4edba8329453a8ed0478dcc49389c
> Dump complete
>
> From my latest build of master.
Doesn't happen to me, FWIW.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-09 10:48 ` Eli Zaretskii
@ 2019-03-09 13:15 ` martin rudalics
2019-03-09 15:10 ` Stefan Monnier
0 siblings, 1 reply; 15+ messages in thread
From: martin rudalics @ 2019-03-09 13:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: michael_heerdegen, monnier, emacs-devel
> Doesn't happen to me, FWIW.
Reliably reproducible so far here.
martin
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-09 13:15 ` martin rudalics
@ 2019-03-09 15:10 ` Stefan Monnier
2019-03-10 8:46 ` martin rudalics
0 siblings, 1 reply; 15+ messages in thread
From: Stefan Monnier @ 2019-03-09 15:10 UTC (permalink / raw)
To: martin rudalics; +Cc: michael_heerdegen, Eli Zaretskii, emacs-devel
>> Doesn't happen to me, FWIW.
> Reliably reproducible so far here.
Even after a full bootstrap?
In order for the fix to "take effect" you need (in order of appearance):
- recompile autoload.el.
- either modify pcase.el or remove loaddefs.el to rebuild it
from scratch.
- make autoloads
Stefan
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: No docstring slot for pcase--make-docstring
2019-03-09 15:10 ` Stefan Monnier
@ 2019-03-10 8:46 ` martin rudalics
2019-03-10 17:22 ` Stefan Monnier
0 siblings, 1 reply; 15+ messages in thread
From: martin rudalics @ 2019-03-10 8:46 UTC (permalink / raw)
To: Stefan Monnier; +Cc: michael_heerdegen, Eli Zaretskii, emacs-devel
>> Reliably reproducible so far here.
>
> Even after a full bootstrap?
I did not try that.
> In order for the fix to "take effect" you need (in order of appearance):
> - recompile autoload.el.
> - either modify pcase.el or remove loaddefs.el to rebuild it
> from scratch.
It seems that recompiling pcase.el indeed helps.
> - make autoloads
I forgot in which directory to do that. So far it only tells
me make: *** No rule to make target `autoloads'. Stop.
Thanks, martin
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-10 8:46 ` martin rudalics
@ 2019-03-10 17:22 ` Stefan Monnier
2019-03-11 9:14 ` martin rudalics
0 siblings, 1 reply; 15+ messages in thread
From: Stefan Monnier @ 2019-03-10 17:22 UTC (permalink / raw)
To: martin rudalics; +Cc: michael_heerdegen, Eli Zaretskii, emacs-devel
>> Even after a full bootstrap?
> I did not try that.
Can't blame you: I didn't either.
>> In order for the fix to "take effect" you need (in order of appearance):
>> - recompile autoload.el.
>> - either modify pcase.el or remove loaddefs.el to rebuild it
>> from scratch.
> It seems that recompiling pcase.el indeed helps.
I think changing the modtime of pcase.el is what it takes (so that "make
autoloads" reconsults pcase.el).
>> - make autoloads
> I forgot in which directory to do that. So far it only tells
> me make: *** No rule to make target `autoloads'. Stop.
(cd lisp; make autoloads)
Stefan
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: No docstring slot for pcase--make-docstring
2019-03-10 17:22 ` Stefan Monnier
@ 2019-03-11 9:14 ` martin rudalics
2019-03-11 12:01 ` Noam Postavsky
0 siblings, 1 reply; 15+ messages in thread
From: martin rudalics @ 2019-03-11 9:14 UTC (permalink / raw)
To: Stefan Monnier; +Cc: michael_heerdegen, Eli Zaretskii, emacs-devel
> (cd lisp; make autoloads)
In the lisp source directory apparently. That reruns configure here,
wants my standard compiler options and bows out with an error when it
doesn't find all libraries. Unusable so far here.
martin
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-11 9:14 ` martin rudalics
@ 2019-03-11 12:01 ` Noam Postavsky
2019-04-23 9:14 ` martin rudalics
0 siblings, 1 reply; 15+ messages in thread
From: Noam Postavsky @ 2019-03-11 12:01 UTC (permalink / raw)
To: martin rudalics
Cc: Michael Heerdegen, Eli Zaretskii, Stefan Monnier,
Emacs developers
On Mon, 11 Mar 2019 at 05:33, martin rudalics <rudalics@gmx.at> wrote:
>
> > (cd lisp; make autoloads)
>
> In the lisp source directory apparently. That reruns configure here,
> wants my standard compiler options and bows out with an error when it
> doesn't find all libraries. Unusable so far here.
If you're building out-of-tree, that should be lisp/ of the build directory.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: No docstring slot for pcase--make-docstring
2019-03-11 12:01 ` Noam Postavsky
@ 2019-04-23 9:14 ` martin rudalics
0 siblings, 0 replies; 15+ messages in thread
From: martin rudalics @ 2019-04-23 9:14 UTC (permalink / raw)
To: Noam Postavsky; +Cc: Emacs developers
>> > (cd lisp; make autoloads)
>>
>> In the lisp source directory apparently. That reruns configure here,
>> wants my standard compiler options and bows out with an error when it
>> doesn't find all libraries. Unusable so far here.
>
> If you're building out-of-tree, that should be lisp/ of the build directory.
I see. Logical but slightly confusing because the file is recreated
in the lisp/ of the source directory.
Thanks, martin
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-04-23 9:14 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 9:39 No docstring slot for pcase--make-docstring martin rudalics
2019-03-06 13:36 ` Michael Heerdegen
2019-03-08 6:23 ` Stefan Monnier
2019-03-08 22:28 ` Stefan Monnier
2019-03-09 9:08 ` martin rudalics
2019-03-09 9:12 ` martin rudalics
2019-03-09 9:46 ` martin rudalics
2019-03-09 10:48 ` Eli Zaretskii
2019-03-09 13:15 ` martin rudalics
2019-03-09 15:10 ` Stefan Monnier
2019-03-10 8:46 ` martin rudalics
2019-03-10 17:22 ` Stefan Monnier
2019-03-11 9:14 ` martin rudalics
2019-03-11 12:01 ` Noam Postavsky
2019-04-23 9:14 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).