unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master dddff96: * lisp/help-fns.el: Fix missing dependency
       [not found] ` <20190922165444.5A0C4207FC@vcs0.savannah.gnu.org>
@ 2019-09-22 17:17   ` Lars Ingebrigtsen
  2019-09-22 17:28     ` Juanma Barranquero
  2019-09-22 20:52     ` Noam Postavsky
  0 siblings, 2 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-09-22 17:17 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

monnier@iro.umontreal.ca (Stefan Monnier) writes:

> +(eval-when-compile (require 'subr-x))   ;For when-let.

But when-let is ;;;###-autoloaded now...  isn't that supposed to take
care of stuff when compiling, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master dddff96: * lisp/help-fns.el: Fix missing dependency
  2019-09-22 17:17   ` master dddff96: * lisp/help-fns.el: Fix missing dependency Lars Ingebrigtsen
@ 2019-09-22 17:28     ` Juanma Barranquero
  2019-09-22 20:52     ` Noam Postavsky
  1 sibling, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2019-09-22 17:28 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Stefan Monnier, Emacs developers

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

On Sun, Sep 22, 2019 at 7:18 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:

> But when-let is ;;;###-autoloaded now...  isn't that supposed to take
> care of stuff when compiling, too?

And it and its sibling `when-let*' are used in >25 lisp/*.el files now. At
which point are they useful enough to be moved out of subr-x.el?

[-- Attachment #2: Type: text/html, Size: 448 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master dddff96: * lisp/help-fns.el: Fix missing dependency
  2019-09-22 17:17   ` master dddff96: * lisp/help-fns.el: Fix missing dependency Lars Ingebrigtsen
  2019-09-22 17:28     ` Juanma Barranquero
@ 2019-09-22 20:52     ` Noam Postavsky
  2019-09-22 21:28       ` Stefan Monnier
  1 sibling, 1 reply; 4+ messages in thread
From: Noam Postavsky @ 2019-09-22 20:52 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Stefan Monnier, Emacs developers

On Sun, 22 Sep 2019 at 13:17, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> monnier@iro.umontreal.ca (Stefan Monnier) writes:
>
> > +(eval-when-compile (require 'subr-x))   ;For when-let.
>
> But when-let is ;;;###-autoloaded now...  isn't that supposed to take
> care of stuff when compiling, too?

I think Stefan just needs to do make -C lisp autoloads (I almost made
the same change before realizing this)



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master dddff96: * lisp/help-fns.el: Fix missing dependency
  2019-09-22 20:52     ` Noam Postavsky
@ 2019-09-22 21:28       ` Stefan Monnier
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2019-09-22 21:28 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: Lars Ingebrigtsen, Emacs developers

And the winner is...

> I think Stefan just needs to do make -C lisp autoloads (I almost made
> the same change before realizing this)


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-09-22 21:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190922165443.14019.71341@vcs0.savannah.gnu.org>
     [not found] ` <20190922165444.5A0C4207FC@vcs0.savannah.gnu.org>
2019-09-22 17:17   ` master dddff96: * lisp/help-fns.el: Fix missing dependency Lars Ingebrigtsen
2019-09-22 17:28     ` Juanma Barranquero
2019-09-22 20:52     ` Noam Postavsky
2019-09-22 21:28       ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).