unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Matthew Trzcinski <matt@excalamus.com>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/org 26ef5e3e5b: org-src: Use `sh-mode' for all the shells it can handle
Date: Mon, 17 Apr 2023 12:08:51 -0400	[thread overview]
Message-ID: <jwv8req8phw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20230417155805.3E200C1391A@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 17 Apr 2023 11:58:05 -0400 (EDT)")

>  (defcustom org-src-lang-modes
> -  '(("C" . c)
> +  `(("C" . c)
>      ("C++" . c++)
>      ("asymptote" . asy)
> -    ("bash" . sh)
>      ("beamer" . latex)
>      ("calc" . fundamental)
>      ("cpp" . c++)
> @@ -208,9 +215,10 @@ but which mess up the display of a snippet in Org exported files.")
>      ("elisp" . emacs-lisp)
>      ("ocaml" . tuareg)
>      ("screen" . shell-script)
> -    ("shell" . sh)
>      ("sqlite" . sql)
> -    ("toml" . conf-toml))
> +    ("toml" . conf-toml)
> +    ("shell" . sh)
> +    ,@(org-src--get-known-shells))
>    "Alist mapping languages to their major mode.

Side note: while it really doesn't matter here for such trivial
top-level code, I prefer to put such ,@ at the beginning rather than the
end of lists, when it's an option.  Basically because it's more
efficient to add to the beginning rather than to the end of a list:

    ELISP> (macroexpand '`(,@(list 1 2) a b c d))
    (append (list 1 2) '(a b c d))
    ELISP> (macroexpand '`(a b c d ,@(list 1 2)))
    (cons 'a (cons 'b (cons 'c (cons 'd (list 1 2)))))
    ELISP>


-- Stefan




       reply	other threads:[~2023-04-17 16:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168174708495.14139.12756054653439048176@vcs2.savannah.gnu.org>
     [not found] ` <20230417155805.3E200C1391A@vcs2.savannah.gnu.org>
2023-04-17 16:08   ` Stefan Monnier [this message]
2023-04-17 16:16     ` [elpa] externals/org 26ef5e3e5b: org-src: Use `sh-mode' for all the shells it can handle Lynn Winebarger
2023-04-17 16:27       ` Philip Kaludercic
2023-04-17 16:37         ` Andreas Schwab
2023-04-17 16:42           ` Philip Kaludercic
2023-04-17 16:39         ` Mattias Engdegård
2023-04-17 16:47           ` Mattias Engdegård
2023-04-17 17:37           ` Stefan Monnier
2023-04-17 18:33             ` Mattias Engdegård
2023-04-17 20:08               ` Stefan Monnier
2023-04-18  9:50                 ` Mattias Engdegård
2023-04-17 17:11       ` Stefan Monnier
2023-04-17 17:24         ` Lynn Winebarger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8req8phw.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=matt@excalamus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).