From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r114939: * lisp/progmodes/ruby-mode.el (ruby-mode): Clean up docstring.
Date: Mon, 04 Nov 2013 11:43:21 -0500 [thread overview]
Message-ID: <jwv7gcoktr3.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1VdL1r-0000Yy-3H@vcs.savannah.gnu.org> (Bozhidar Batsov's message of "Mon, 04 Nov 2013 14:21:19 +0000")
> +Entry to this mode calls the value of `ruby-mode-hook'
> +if that value is non-nil."
That's problematic:
- it's redundant since define-derived-mode already adds "In addition to
any hooks its parent mode `prog-mode' might have run,\nthis mode runs
the hook `ruby-mode-hook', as the final step\nduring initialization."
- hooks aren't "called" but are "run".
- it's not just "the value of `ruby-mode-hook'", but the *values*, since
hooks use both the buffer-local and the global value of the symbol.
- the hook is run even if it is nil (or unbound): running it will simply
not do anything.
Stefan
next parent reply other threads:[~2013-11-04 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VdL1r-0000Yy-3H@vcs.savannah.gnu.org>
2013-11-04 16:43 ` Stefan Monnier [this message]
2013-11-04 17:04 ` [Emacs-diffs] trunk r114939: * lisp/progmodes/ruby-mode.el (ruby-mode): Clean up docstring Bozhidar Batsov
2013-11-04 17:05 ` Bozhidar Batsov
2013-11-04 18:50 ` Stefan Monnier
2013-11-05 10:22 ` Bozhidar Batsov
2013-11-05 17:01 ` Stefan Monnier
2013-11-05 17:14 ` Bozhidar Batsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7gcoktr3.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bozhidar@batsov.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).